Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Mathieu Poirier
On Tue, 28 Jul 2020 at 06:02, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > > - Firstly, the function auxtrace_record__init() will be invoked only > > > once, the variable "a

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Leo Yan
Hi Arnaldo, On Tue, Jul 28, 2020 at 09:02:20AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > > - Firstly, the function auxtrace_record__init() will be invoked only > > >

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > - Firstly, the function auxtrace_record__init() will be invoked only > > once, the variable "arm_spe_pmus" will not be used afterwards, thus > > we don't need to che

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > - Firstly, the function auxtrace_record__init() will be invoked only > > once, the variable "arm_spe_pmus" will not be used afterwards, thus > > we don't need to che

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-27 Thread Mathieu Poirier
On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > - Firstly, the function auxtrace_record__init() will be invoked only > once, the variable "arm_spe_pmus" will not be used afterwards, thus > we don't need to check "arm_spe_pmus" is NULL or not; > - Another reason is, even though SPE is

[PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-24 Thread Wei Li
- Firstly, the function auxtrace_record__init() will be invoked only once, the variable "arm_spe_pmus" will not be used afterwards, thus we don't need to check "arm_spe_pmus" is NULL or not; - Another reason is, even though SPE is micro-architecture dependent, but so far it only supports "sta