Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wednesday 06 January 2016 20:56:28 Bamvor Jian Zhang wrote: > >> > >> That reminds me, we should now remove the code from fs/compat_ioctl.c > >> that was handling emulating the other ioctl commands, the new .compat_ioctl > >> callback in ppdev takes care of that along with the

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wednesday 06 January 2016 20:56:28 Bamvor Jian Zhang wrote: > >> > >> That reminds me, we should now remove the code from fs/compat_ioctl.c > >> that was handling emulating the other ioctl commands, the new .compat_ioctl > >> callback in ppdev takes care of that along with the

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Sudip On 01/04/2016 09:14 PM, Sudip Mukherjee wrote: > On Sat, Jan 02, 2016 at 11:40:51PM +0100, Arnd Bergmann wrote: >> On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: Just to be sure we are talking about the same thing: you mean running a 64-bit kernel in a

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Sudip On 01/04/2016 09:14 PM, Sudip Mukherjee wrote: > On Sat, Jan 02, 2016 at 11:40:51PM +0100, Arnd Bergmann wrote: >> On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: Just to be sure we are talking about the same thing: you mean running a 64-bit kernel in a

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Monday 04 January 2016 18:44:52 Sudip Mukherjee wrote: > > > > If 'uname -i' reports i686, that usually means you have configured the > > kernel for 32-bit. Try rebuilding the kernel with 'CONFIG_64BIT' and > > 'CONFIG_IA32_EMULATION' enabled to test that the 32-bit user space now > > also

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Sat, Jan 02, 2016 at 11:40:51PM +0100, Arnd Bergmann wrote: > On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: > > > > > > Just to be sure we are talking about the same thing: you mean running a > > > 64-bit > > > kernel in a kvm guest with a 32-bit file system, right? Running a

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Sat, Jan 02, 2016 at 11:40:51PM +0100, Arnd Bergmann wrote: > On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: > > > > > > Just to be sure we are talking about the same thing: you mean running a > > > 64-bit > > > kernel in a kvm guest with a 32-bit file system, right? Running a

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Monday 04 January 2016 18:44:52 Sudip Mukherjee wrote: > > > > If 'uname -i' reports i686, that usually means you have configured the > > kernel for 32-bit. Try rebuilding the kernel with 'CONFIG_64BIT' and > > 'CONFIG_IA32_EMULATION' enabled to test that the 32-bit user space now > > also

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: > > > > Just to be sure we are talking about the same thing: you mean running a > > 64-bit > > kernel in a kvm guest with a 32-bit file system, right? Running a 32-bit > > kvm guest on a 64-bit host would not be interesting of course. >

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Saturday 02 January 2016 11:59:29 Sudip Mukherjee wrote: > > > > Just to be sure we are talking about the same thing: you mean running a > > 64-bit > > kernel in a kvm guest with a 32-bit file system, right? Running a 32-bit > > kvm guest on a 64-bit host would not be interesting of course. >

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Fri, Jan 01, 2016 at 11:09:45PM +0100, Arnd Bergmann wrote: > On Friday 01 January 2016 10:34:25 Sudip Mukherjee wrote: > > > Did you happen to check with both 32-bit and 64-bit user space on a > > > 64-bit kernel? This is one of the things that was not working originally > > > but should work

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Friday 01 January 2016 10:34:25 Sudip Mukherjee wrote: > > Did you happen to check with both 32-bit and 64-bit user space on a > > 64-bit kernel? This is one of the things that was not working originally > > but should work now. > > I dont think I can manage 32 bit userspace on 64-bit kernel

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Fri, Jan 01, 2016 at 11:09:45PM +0100, Arnd Bergmann wrote: > On Friday 01 January 2016 10:34:25 Sudip Mukherjee wrote: > > > Did you happen to check with both 32-bit and 64-bit user space on a > > > 64-bit kernel? This is one of the things that was not working originally > > > but should work

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Friday 01 January 2016 10:34:25 Sudip Mukherjee wrote: > > Did you happen to check with both 32-bit and 64-bit user space on a > > 64-bit kernel? This is one of the things that was not working originally > > but should work now. > > I dont think I can manage 32 bit userspace on 64-bit kernel

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thu, Dec 31, 2015 at 03:12:11PM +0100, Arnd Bergmann wrote: > On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote: > > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > > > On Wednesday 30 December 2015 21:24:21

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote: > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > > >> diff --git a/drivers/char/ppdev.c

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > Hi, Arnd > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > >> index 31bc7b7..9e98d01 100644 > >>

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > Hi, Arnd > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > >> index 31bc7b7..9e98d01 100644 > >>

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote: > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > > >> diff --git a/drivers/char/ppdev.c

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thu, Dec 31, 2015 at 03:12:11PM +0100, Arnd Bergmann wrote: > On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote: > > On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote: > > > On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > > > > On Wednesday 30 December 2015 21:24:21

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Arnd On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c >> index 31bc7b7..9e98d01 100644 >> --- a/drivers/char/ppdev.c >> +++ b/drivers/char/ppdev.c >> @@ -636,7 +636,7 @@

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > index 31bc7b7..9e98d01 100644 > --- a/drivers/char/ppdev.c > +++ b/drivers/char/ppdev.c > @@ -636,7 +636,7 @@ static int pp_do_ioctl(struct file *file, unsigned int > cmd,

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wed, Dec 30, 2015 at 09:24:21PM +0800, Bamvor Jian Zhang wrote: > Hi, Sudip > > On 12/30/2015 07:16 PM, Sudip Mukherjee wrote: > > On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: > >> On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > >>> The arg of ioctl in ppdev

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Sudip On 12/30/2015 07:16 PM, Sudip Mukherjee wrote: > On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: >> On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: >>> The arg of ioctl in ppdev is the pointer of integer except the >>> timeval in PPSETTIME, PPGETTIME.

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: > On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > > The arg of ioctl in ppdev is the pointer of integer except the > > timeval in PPSETTIME, PPGETTIME. Different size of timeval > > is already supported by the previous

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: > On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > > The arg of ioctl in ppdev is the pointer of integer except the > > timeval in PPSETTIME, PPGETTIME. Different size of timeval > > is already supported by the previous

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wed, Dec 30, 2015 at 09:24:21PM +0800, Bamvor Jian Zhang wrote: > Hi, Sudip > > On 12/30/2015 07:16 PM, Sudip Mukherjee wrote: > > On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: > >> On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > >>> The arg of ioctl in ppdev

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > index 31bc7b7..9e98d01 100644 > --- a/drivers/char/ppdev.c > +++ b/drivers/char/ppdev.c > @@ -636,7 +636,7 @@ static int pp_do_ioctl(struct file *file, unsigned int > cmd,

Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Arnd On 12/30/2015 09:51 PM, Arnd Bergmann wrote: > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c >> index 31bc7b7..9e98d01 100644 >> --- a/drivers/char/ppdev.c >> +++ b/drivers/char/ppdev.c >> @@ -636,7 +636,7 @@

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

Hi, Sudip On 12/30/2015 07:16 PM, Sudip Mukherjee wrote: > On Fri, Dec 18, 2015 at 12:12:05AM +0100, Arnd Bergmann wrote: >> On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: >>> The arg of ioctl in ppdev is the pointer of integer except the >>> timeval in PPSETTIME, PPGETTIME.

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > The arg of ioctl in ppdev is the pointer of integer except the > timeval in PPSETTIME, PPGETTIME. Different size of timeval > is already supported by the previous patches. So, it is safe > to add compat support. > > Signed-off-by:

[PATCH v2 2/2] ppdev: add support for compat ioctl

The arg of ioctl in ppdev is the pointer of integer except the timeval in PPSETTIME, PPGETTIME. Different size of timeval is already supported by the previous patches. So, it is safe to add compat support. Signed-off-by: Bamvor Jian Zhang --- drivers/char/ppdev.c | 12 1 file

[PATCH v2 2/2] ppdev: add support for compat ioctl

The arg of ioctl in ppdev is the pointer of integer except the timeval in PPSETTIME, PPGETTIME. Different size of timeval is already supported by the previous patches. So, it is safe to add compat support. Signed-off-by: Bamvor Jian Zhang --- drivers/char/ppdev.c |

Re: [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thursday 17 December 2015 17:58:52 Bamvor Jian Zhang wrote: > The arg of ioctl in ppdev is the pointer of integer except the > timeval in PPSETTIME, PPGETTIME. Different size of timeval > is already supported by the previous patches. So, it is safe > to add compat support. > > Signed-off-by: