Re: [PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC

2018-07-11 Thread Mark Brown
On Wed, Jul 11, 2018 at 11:31:35AM +0900, Kunihiko Hayashi wrote: > On Tue, 10 Jul 2018 18:44:51 +0100 wrote: > > On Tue, Jul 10, 2018 at 10:27:17AM +0900, Kunihiko Hayashi wrote: > > This isn't *quite* regulator_is_enabled_regmap() as it explicitly checks > > if the disable value is set and erro

Re: [PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC

2018-07-10 Thread Kunihiko Hayashi
Hi Mark, On Tue, 10 Jul 2018 18:44:51 +0100 wrote: > On Tue, Jul 10, 2018 at 10:27:17AM +0900, Kunihiko Hayashi wrote: > > > +static int uniphier_regulator_enable(struct regulator_dev *rdev) > > +{ > > + struct uniphier_regulator_priv *priv = rdev_get_drvdata(rdev); > > + > > + return regma

Re: [PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC

2018-07-10 Thread Mark Brown
On Tue, Jul 10, 2018 at 10:27:17AM +0900, Kunihiko Hayashi wrote: > +static int uniphier_regulator_enable(struct regulator_dev *rdev) > +{ > + struct uniphier_regulator_priv *priv = rdev_get_drvdata(rdev); > + > + return regmap_update_bits(priv->regmap, rdev->desc->enable_reg, > +

[PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC

2018-07-09 Thread Kunihiko Hayashi
Initial commit to add support for regulators implemented in UniPhier SoCs. This supports USB VBUS only. Signed-off-by: Kunihiko Hayashi --- drivers/regulator/Kconfig | 8 ++ drivers/regulator/Makefile | 1 + drivers/regulator/uniphier-regulator.c | 247 ++