Re: [PATCH v2 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

On Mon, Jul 22, 2019 at 3:59 PM Vaibhav Rustagi wrote: > The changes suggested will cause undefined symbols while loading the new > kernel. > On doing 'nm purgatory.ro', I found below undefined symbols: > > U bmcp > U __stack_chk_fail Thanks for the report, a v3:

Re: [PATCH v2 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

On Mon, Jul 22, 2019 at 3:10 PM Nick Desaulniers wrote: > > On Mon, Jul 22, 2019 at 2:33 PM Nick Desaulniers > wrote: > > > > KBUILD_CFLAGS is very carefully built up in the top level Makefile, > > particularly when cross compiling or using different build tools. > > Resetting KBUILD_CFLAGS via

Re: [PATCH v2 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

On Mon, Jul 22, 2019 at 2:33 PM Nick Desaulniers wrote: > > KBUILD_CFLAGS is very carefully built up in the top level Makefile, > particularly when cross compiling or using different build tools. > Resetting KBUILD_CFLAGS via := assignment is an antipattern. > > The comment above the reset

[PATCH v2 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

KBUILD_CFLAGS is very carefully built up in the top level Makefile, particularly when cross compiling or using different build tools. Resetting KBUILD_CFLAGS via := assignment is an antipattern. The comment above the reset mentions that -pg is problematic. Other Makefiles like