Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2016-06-02 Thread Kees Cook
On Thu, Jun 2, 2016 at 12:26 AM, Geliang Tang wrote: > On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: >> On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: >> module_init(efivars_pstore_init); >> >>> >> >>> Looks OK to me. Kees, are you

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2016-06-02 Thread Kees Cook
On Thu, Jun 2, 2016 at 12:26 AM, Geliang Tang wrote: > On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: >> On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: >> module_init(efivars_pstore_init); >> >>> >> >>> Looks OK to me. Kees, are you picking this up? >> >> >> >> I can,

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2016-06-02 Thread Geliang Tang
On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: > On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: > module_init(efivars_pstore_init); > >>> > >>> Looks OK to me. Kees, are you picking this up? > >> > >> I can, though usually it goes through Tony. > > > >

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2016-06-02 Thread Geliang Tang
On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: > On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: > module_init(efivars_pstore_init); > >>> > >>> Looks OK to me. Kees, are you picking this up? > >> > >> I can, though usually it goes through Tony. > > > > Can I count that as

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-12 Thread Matt Fleming
On Wed, 11 Nov, at 11:23:15PM, Luck, Tony wrote: > >>> module_init(efivars_pstore_init); > >> > >> Looks OK to me. Kees, are you picking this up? > > > > I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yep, Acked-by: Matt Fleming -- To

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-12 Thread Matt Fleming
On Wed, 11 Nov, at 11:23:15PM, Luck, Tony wrote: > >>> module_init(efivars_pstore_init); > >> > >> Looks OK to me. Kees, are you picking this up? > > > > I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yep, Acked-by: Matt Fleming

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd acked them already.

RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Luck, Tony
>>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 8:59 AM, Matt Fleming wrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory and set bufsize to 0. >> >>

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Matt Fleming
On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- >

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Matt Fleming
On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- >

RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Luck, Tony
>>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 8:59 AM, Matt Fleming wrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd

[PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-06 Thread Geliang Tang
The original efivars_pstore_exit() is empty. I 1) add a bufsize check statement. 2) call pstore_unregister as it is defined now. 3) free the memory and set bufsize to 0. Signed-off-by: Geliang Tang --- drivers/firmware/efi/efi-pstore.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-06 Thread Geliang Tang
The original efivars_pstore_exit() is empty. I 1) add a bufsize check statement. 2) call pstore_unregister as it is defined now. 3) free the memory and set bufsize to 0. Signed-off-by: Geliang Tang --- drivers/firmware/efi/efi-pstore.c | 7 +++ 1 file changed, 7