Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Sergey Senozhatsky
On (20/07/31 16:48), Steven Rostedt wrote: [..] > > > - static const struct printf_spec num_spec = { > > > - .flags = SMALL, > > > - .field_width = -1, > > > - .precision = -1, > > > - .base = 10, > > > - }; > > > > > > struct printf_spec str_spec = spec; > > >

Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Sergey Senozhatsky
On (20/07/31 21:08), Andy Shevchenko wrote: > When printing phandle via %pOFp the custom spec is used. First of all, > it has a SMALL flag which makes no sense for decimal numbers. Second, > we have already default spec for decimal numbers. Use the latter in > the %pOFp case as well. > > Cc:

Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Steven Rostedt
On Fri, 31 Jul 2020 11:20:21 -0700 Joe Perches wrote: > On Fri, 2020-07-31 at 21:08 +0300, Andy Shevchenko wrote: > > When printing phandle via %pOFp the custom spec is used. First of all, > > it has a SMALL flag which makes no sense for decimal numbers. Second, > > we have already default spec

Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Joe Perches
On Fri, 2020-07-31 at 21:08 +0300, Andy Shevchenko wrote: > When printing phandle via %pOFp the custom spec is used. First of all, > it has a SMALL flag which makes no sense for decimal numbers. Second, > we have already default spec for decimal numbers. Use the latter in > the %pOFp case as well.

Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Andy Shevchenko
On Fri, Jul 31, 2020 at 09:08:23PM +0300, Andy Shevchenko wrote: > When printing phandle via %pOFp the custom spec is used. First of all, > it has a SMALL flag which makes no sense for decimal numbers. Second, > we have already default spec for decimal numbers. Use the latter in > the %pOFp case

[PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one

2020-07-31 Thread Andy Shevchenko
When printing phandle via %pOFp the custom spec is used. First of all, it has a SMALL flag which makes no sense for decimal numbers. Second, we have already default spec for decimal numbers. Use the latter in the %pOFp case as well. Cc: Pantelis Antoniou Cc: Rob Herring Cc: Joe Perches Cc: