Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-15 Thread Claudiu.Beznea
On 15.01.2019 00:53, Mark Brown wrote: > On Fri, Jan 11, 2019 at 02:08:19PM +, claudiu.bez...@microchip.com wrote: >> On 11.01.2019 14:39, Mark Brown wrote: > >>> Like I say I'm working offline so I can't check the links but it sounds >>> like you're saying that the existing suspend mode co

Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-14 Thread Mark Brown
On Fri, Jan 11, 2019 at 02:08:19PM +, claudiu.bez...@microchip.com wrote: > On 11.01.2019 14:39, Mark Brown wrote: > > Like I say I'm working offline so I can't check the links but it sounds > > like you're saying that the existing suspend mode configuration features > > are enough for your sy

Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-11 Thread Claudiu.Beznea
On 11.01.2019 14:39, Mark Brown wrote: > On Thu, Jan 10, 2019 at 10:24:26AM +, claudiu.bez...@microchip.com wrote: >> On 09.01.2019 18:57, Mark Brown wrote: > >>> regulator state which feels fragile. But based on the cover letter >>> that's kind of like what the initial proposal about targ

Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-11 Thread Mark Brown
On Thu, Jan 10, 2019 at 10:24:26AM +, claudiu.bez...@microchip.com wrote: > On 09.01.2019 18:57, Mark Brown wrote: > > regulator state which feels fragile. But based on the cover letter > > that's kind of like what the initial proposal about target states was so > > perhaps this is the way we

Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-10 Thread Claudiu.Beznea
On 09.01.2019 18:57, Mark Brown wrote: > On Tue, Jan 08, 2019 at 10:56:32AM +, claudiu.bez...@microchip.com wrote: >> From: Claudiu Beznea >> >> Add helper to check if regulator will be disabled in suspend. >> >> Signed-off-by: Claudiu Beznea > > This feels like it's the wrong way round -

Re: [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-09 Thread Mark Brown
On Tue, Jan 08, 2019 at 10:56:32AM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > Add helper to check if regulator will be disabled in suspend. > > Signed-off-by: Claudiu Beznea This feels like it's the wrong way round - if this is configurable I'd expect something to co

[PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled in suspend

2019-01-08 Thread Claudiu.Beznea
From: Claudiu Beznea Add helper to check if regulator will be disabled in suspend. Signed-off-by: Claudiu Beznea --- drivers/regulator/core.c | 17 + include/linux/regulator/consumer.h | 7 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/regulator/cor