Re: [PATCH v2 2/3] tracing: Fix parse_synth_field() error handling

Hi Masami, On Thu, 2020-10-01 at 14:27 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Wed, 30 Sep 2020 13:40:51 -0500 > Tom Zanussi wrote: > > > synth_field_size() returns either a positive size or an error (zero > > or > > a negative value). However, the existing code assumes the only > > err

Re: [PATCH v2 2/3] tracing: Fix parse_synth_field() error handling

Hi Tom, On Wed, 30 Sep 2020 13:40:51 -0500 Tom Zanussi wrote: > synth_field_size() returns either a positive size or an error (zero or > a negative value). However, the existing code assumes the only error > value is 0. It doesn't handle negative error codes, as it assigns > directly to field->s

[PATCH v2 2/3] tracing: Fix parse_synth_field() error handling

synth_field_size() returns either a positive size or an error (zero or a negative value). However, the existing code assumes the only error value is 0. It doesn't handle negative error codes, as it assigns directly to field->size (a size_t; unsigned), thereby interpreting the error code as a valid