Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Greg Kroah-Hartman
On Wed, May 09, 2018 at 03:32:16PM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, May 9, 2018 at 12:39 PM, Russell King - ARM Linux > wrote: > > On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Apr 26, 2018 at 10:35 AM, Greg

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Greg Kroah-Hartman
On Wed, May 09, 2018 at 03:32:16PM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, May 9, 2018 at 12:39 PM, Russell King - ARM Linux > wrote: > > On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman > >> wrote:

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Geert Uytterhoeven
Hi Russell, On Wed, May 9, 2018 at 12:39 PM, Russell King - ARM Linux wrote: > On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: >> On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman >> wrote: >> > On Thu, Apr 26, 2018 at

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Geert Uytterhoeven
Hi Russell, On Wed, May 9, 2018 at 12:39 PM, Russell King - ARM Linux wrote: > On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: >> On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman >> wrote: >> > On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: >> >> On

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Russell King - ARM Linux
On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Apr 26, 2018 at 9:04 AM, Greg

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-05-09 Thread Russell King - ARM Linux
On Thu, Apr 26, 2018 at 10:45:49AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: > >> On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman > >> wrote: > >> > On

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Geert Uytterhoeven
Hi Greg, On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman wrote: > On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: >> On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman >> wrote: >> > On Wed, Apr 25, 2018 at

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Geert Uytterhoeven
Hi Greg, On Thu, Apr 26, 2018 at 10:35 AM, Greg Kroah-Hartman wrote: > On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: >> On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman >> wrote: >> > On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: >> >> On Wed, Apr

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Greg Kroah-Hartman
On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman > wrote: > > On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: > >> On Wed, Apr 25, 2018 at 6:06 PM, Greg

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Greg Kroah-Hartman
On Thu, Apr 26, 2018 at 09:40:08AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman > wrote: > > On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: > >> On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman > >> wrote: > >> > On

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Geert Uytterhoeven
Hi Greg, On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: >> On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Apr 10, 2018 at

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Geert Uytterhoeven
Hi Greg, On Thu, Apr 26, 2018 at 9:04 AM, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: >> On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: >> >> The

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Greg Kroah-Hartman
On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman > wrote: > > On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: > >> The driver_override implementation is

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-26 Thread Greg Kroah-Hartman
On Wed, Apr 25, 2018 at 07:53:06PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman > wrote: > > On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: > >> The driver_override implementation is susceptible to a race condition > >>

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Geert Uytterhoeven
Hi Greg, On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: >> The driver_override implementation is susceptible to a race condition >> when different threads are reading vs storing a

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Geert Uytterhoeven
Hi Greg, On Wed, Apr 25, 2018 at 6:06 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: >> The driver_override implementation is susceptible to a race condition >> when different threads are reading vs storing a different driver >> override. Add

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: > The driver_override implementation is susceptible to a race condition > when different threads are reading vs storing a different driver > override. Add locking to avoid this race condition. > > Cfr. commits 6265539776a0810b

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 10, 2018 at 03:21:44PM +0200, Geert Uytterhoeven wrote: > The driver_override implementation is susceptible to a race condition > when different threads are reading vs storing a different driver > override. Add locking to avoid this race condition. > > Cfr. commits 6265539776a0810b

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Todd Kjos
Reviewed-by: Todd Kjos On Tue, Apr 10, 2018 at 6:21 AM, Geert Uytterhoeven wrote: > The driver_override implementation is susceptible to a race condition > when different threads are reading vs storing a different driver > override. Add locking to

Re: [PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-25 Thread Todd Kjos
Reviewed-by: Todd Kjos On Tue, Apr 10, 2018 at 6:21 AM, Geert Uytterhoeven wrote: > The driver_override implementation is susceptible to a race condition > when different threads are reading vs storing a different driver > override. Add locking to avoid this race condition. > > Cfr. commits

[PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-10 Thread Geert Uytterhoeven
The driver_override implementation is susceptible to a race condition when different threads are reading vs storing a different driver override. Add locking to avoid this race condition. Cfr. commits 6265539776a0810b ("driver core: platform: fix race condition with driver_override") and

[PATCH v2 2/4] ARM: amba: Fix race condition with driver_override

2018-04-10 Thread Geert Uytterhoeven
The driver_override implementation is susceptible to a race condition when different threads are reading vs storing a different driver override. Add locking to avoid this race condition. Cfr. commits 6265539776a0810b ("driver core: platform: fix race condition with driver_override") and