Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-23 Thread Lee Jones
On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this can't

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-23 Thread Lee Jones
On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this can't

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-15 Thread Chanwoo Choi
Hi, On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-15 Thread Chanwoo Choi
Hi, On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-13 Thread Krzysztof Kozlowski
On Fri, Jan 13, 2017 at 10:34:06AM -0300, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense

Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-13 Thread Krzysztof Kozlowski
On Fri, Jan 13, 2017 at 10:34:06AM -0300, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense

[PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-13 Thread Javier Martinez Canillas
Use the generic helper to get the matched of_device_id .data, instead of open coding it. The driver was checking if matching the OF node with the driver's OF table was failing, but this doesn't make too much sense since this can't happen in practice. The fact the probe function was called, means

[PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper

2017-01-13 Thread Javier Martinez Canillas
Use the generic helper to get the matched of_device_id .data, instead of open coding it. The driver was checking if matching the OF node with the driver's OF table was failing, but this doesn't make too much sense since this can't happen in practice. The fact the probe function was called, means