Re: [PATCH v2 2/4] tee: optee: add TEE bus device enumeration support

2019-01-11 Thread Sumit Garg
On Fri, 11 Jan 2019 at 15:09, Daniel Thompson wrote: > > On Fri, Jan 11, 2019 at 12:52:19PM +0530, Sumit Garg wrote: > > On Thu, 10 Jan 2019 at 19:49, Daniel Thompson > > wrote: > > > > +static int get_devices(struct tee_context *ctx, u32 session, > > > > +struct tee_shm *devi

Re: [PATCH v2 2/4] tee: optee: add TEE bus device enumeration support

2019-01-11 Thread Daniel Thompson
On Fri, Jan 11, 2019 at 12:52:19PM +0530, Sumit Garg wrote: > On Thu, 10 Jan 2019 at 19:49, Daniel Thompson > wrote: > > > +static int get_devices(struct tee_context *ctx, u32 session, > > > +struct tee_shm *device_uuid, u32 *shm_size) > > > > Missing const on device_uuid? > >

Re: [PATCH v2 2/4] tee: optee: add TEE bus device enumeration support

2019-01-10 Thread Sumit Garg
On Thu, 10 Jan 2019 at 19:49, Daniel Thompson wrote: > > On Thu, Jan 10, 2019 at 05:54:55PM +0530, Sumit Garg wrote: > > OP-TEE provides a pseudo TA to enumerate TAs which can act as devices/ > > services for TEE bus. So implement device enumeration using invoke > > function: PTA_CMD_GET_DEVICES p

Re: [PATCH v2 2/4] tee: optee: add TEE bus device enumeration support

2019-01-10 Thread Daniel Thompson
On Thu, Jan 10, 2019 at 05:54:55PM +0530, Sumit Garg wrote: > OP-TEE provides a pseudo TA to enumerate TAs which can act as devices/ > services for TEE bus. So implement device enumeration using invoke > function: PTA_CMD_GET_DEVICES provided by pseudo TA to fetch array of > device UUIDs. Also regi

[PATCH v2 2/4] tee: optee: add TEE bus device enumeration support

2019-01-10 Thread Sumit Garg
OP-TEE provides a pseudo TA to enumerate TAs which can act as devices/ services for TEE bus. So implement device enumeration using invoke function: PTA_CMD_GET_DEVICES provided by pseudo TA to fetch array of device UUIDs. Also register these enumerated devices with TEE bus as "optee-clntX" device.