Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-15 Thread Guido Günther
Hi, On Sun, Feb 14, 2021 at 09:41:27PM +0100, Luc Van Oostenryck wrote: > On Sun, Feb 14, 2021 at 11:00:48AM -0800, Linus Torvalds wrote: > > On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones > > wrote: > > > > > > > > > > > I looked around but didn't find any hints how to fix this. Any pointers > > >

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Luc Van Oostenryck
On Sun, Feb 14, 2021 at 11:00:48AM -0800, Linus Torvalds wrote: > On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones > wrote: > > > > > > > > I looked around but didn't find any hints how to fix this. Any pointers > > > I missed (added the sparse list to cc:)? > > > > This is a limitation of sparse; wh

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Ramsay Jones
On 14/02/2021 19:00, Linus Torvalds wrote: > On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones > wrote: >> >>> >>> I looked around but didn't find any hints how to fix this. Any pointers >>> I missed (added the sparse list to cc:)? >> >> This is a limitation of sparse; when using the 'stringize' pr

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Linus Torvalds
On Sun, Feb 14, 2021 at 11:00 AM Linus Torvalds wrote: > > The C89 standard actually says that a string literal can be at most > 509 characters to be portable. C99 increased it to 4095 characters. > > Sparse makes the limit higher, and the limit could easily be expanded > way past 8kB - but the po

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Linus Torvalds
On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones wrote: > > > > > I looked around but didn't find any hints how to fix this. Any pointers > > I missed (added the sparse list to cc:)? > > This is a limitation of sparse; when using the 'stringize' pre-processor > operator #, the maximum size of the res

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Guido Günther
Hi , On Sat, Feb 13, 2021 at 11:12:37AM +0800, kernel test robot wrote: > Hi "Guido, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on usb/usb-testing] > [also build test WARNING on v5.11-rc7 next-20210211] > [If your patch is applied to the wrong git tree, kind

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-12 Thread kernel test robot
Hi "Guido, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.11-rc7 next-20210211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-12 Thread Guido Günther
This allows to trace status information which helps to debug problems with role switching, etc. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 26 - drivers/usb/typec/tps6598x.h | 66 + drivers/usb/typec/tps6598x_trace.h | 94 +