Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Huang Rui
On Tue, Jun 09, 2015 at 06:08:41PM +0800, Peter Zijlstra wrote: > On Tue, 2015-06-09 at 18:03 +0800, Huang Rui wrote: > > Why do you think that method is bad? > > I already told you; if people have to use a kernel parameter to use > this, _NOBODY_ will use it. I see. Will revert it. Thanks, Rui

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Peter Zijlstra
On Tue, 2015-06-09 at 18:03 +0800, Huang Rui wrote: > Why do you think that method is bad? I already told you; if people have to use a kernel parameter to use this, _NOBODY_ will use it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Borislav Petkov
On Tue, Jun 09, 2015 at 06:03:10PM +0800, Huang Rui wrote: > Sorry, I am suggested to make the mwaitx delay configurable firstly by > our guys... > Why do you think that method is bad? You're seriously asking that?! Think about it. Who do you think will go and put "mwaitx" in her/his kernel

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Huang Rui
On Tue, Jun 09, 2015 at 05:05:43PM +0800, Borislav Petkov wrote: > On Tue, Jun 09, 2015 at 11:13:39AM +0800, Huang Rui wrote: > > This patch introduces a kernel parameter (delay), user is able to configure > > it at boot loader to choose different types of delay method. > > > > Default schema is

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 11:05:43AM +0200, Borislav Petkov wrote: > And we did talk about this already in the last review. You guys want to > drop all those kernel parameters and use MWAITX delay by default when: > > 1. HW supports MWAITX > > *and* > > 2. delay fits in u32. No, that 2. is just

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Borislav Petkov
On Tue, Jun 09, 2015 at 11:13:39AM +0800, Huang Rui wrote: > This patch introduces a kernel parameter (delay), user is able to configure > it at boot loader to choose different types of delay method. > > Default schema is to use TSC delay. This update can be more flexiable to > add new delay

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 11:05:43AM +0200, Borislav Petkov wrote: And we did talk about this already in the last review. You guys want to drop all those kernel parameters and use MWAITX delay by default when: 1. HW supports MWAITX *and* 2. delay fits in u32. No, that 2. is just

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Huang Rui
On Tue, Jun 09, 2015 at 05:05:43PM +0800, Borislav Petkov wrote: On Tue, Jun 09, 2015 at 11:13:39AM +0800, Huang Rui wrote: This patch introduces a kernel parameter (delay), user is able to configure it at boot loader to choose different types of delay method. Default schema is to use

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Huang Rui
On Tue, Jun 09, 2015 at 06:08:41PM +0800, Peter Zijlstra wrote: On Tue, 2015-06-09 at 18:03 +0800, Huang Rui wrote: Why do you think that method is bad? I already told you; if people have to use a kernel parameter to use this, _NOBODY_ will use it. I see. Will revert it. Thanks, Rui -- To

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Borislav Petkov
On Tue, Jun 09, 2015 at 06:03:10PM +0800, Huang Rui wrote: Sorry, I am suggested to make the mwaitx delay configurable firstly by our guys... Why do you think that method is bad? You're seriously asking that?! Think about it. Who do you think will go and put mwaitx in her/his kernel command

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Peter Zijlstra
On Tue, 2015-06-09 at 18:03 +0800, Huang Rui wrote: Why do you think that method is bad? I already told you; if people have to use a kernel parameter to use this, _NOBODY_ will use it. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-09 Thread Borislav Petkov
On Tue, Jun 09, 2015 at 11:13:39AM +0800, Huang Rui wrote: This patch introduces a kernel parameter (delay), user is able to configure it at boot loader to choose different types of delay method. Default schema is to use TSC delay. This update can be more flexiable to add new delay method.

[PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-08 Thread Huang Rui
This patch introduces a kernel parameter (delay), user is able to configure it at boot loader to choose different types of delay method. Default schema is to use TSC delay. This update can be more flexiable to add new delay method. Suggested-by: Suravee Suthikulanit Signed-off-by: Huang Rui

[PATCH v2 2/4] x86, mwaitt: make delay method configurable

2015-06-08 Thread Huang Rui
This patch introduces a kernel parameter (delay), user is able to configure it at boot loader to choose different types of delay method. Default schema is to use TSC delay. This update can be more flexiable to add new delay method. Suggested-by: Suravee Suthikulanit suravee.suthikulpa...@amd.com