Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-10 Thread Michal Simek
On 04/08/2014 07:27 PM, Jason Gunthorpe wrote: > On Tue, Apr 08, 2014 at 09:03:27AM +0200, Michal Simek wrote: > >>> If in doubt follow common mainline practice. Although using includes >>> for DT is not necessarily common practice, readability of DTs is >>> really important IMHO. >> >> Let me

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-10 Thread Michal Simek
On 04/08/2014 07:27 PM, Jason Gunthorpe wrote: On Tue, Apr 08, 2014 at 09:03:27AM +0200, Michal Simek wrote: If in doubt follow common mainline practice. Although using includes for DT is not necessarily common practice, readability of DTs is really important IMHO. Let me give you one

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-08 Thread Jason Gunthorpe
On Tue, Apr 08, 2014 at 09:03:27AM +0200, Michal Simek wrote: > > If in doubt follow common mainline practice. Although using includes > > for DT is not necessarily common practice, readability of DTs is > > really important IMHO. > > Let me give you one example. When you add xilinx intc

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-08 Thread Michal Simek
On 04/07/2014 08:02 PM, Steffen Trumtrar wrote: > Hi! > > On Mon, Apr 07, 2014 at 11:10:12AM -0600, Jason Gunthorpe wrote: >> On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: >> >>> Device-tree BSP and in 2014.01 there will be new BSP which just >>> generate them directly from the

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-08 Thread Michal Simek
On 04/07/2014 08:02 PM, Steffen Trumtrar wrote: Hi! On Mon, Apr 07, 2014 at 11:10:12AM -0600, Jason Gunthorpe wrote: On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: Device-tree BSP and in 2014.01 there will be new BSP which just generate them directly from the Vivado tools

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-08 Thread Jason Gunthorpe
On Tue, Apr 08, 2014 at 09:03:27AM +0200, Michal Simek wrote: If in doubt follow common mainline practice. Although using includes for DT is not necessarily common practice, readability of DTs is really important IMHO. Let me give you one example. When you add xilinx intc controller to

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Steffen Trumtrar
Hi! On Mon, Apr 07, 2014 at 11:10:12AM -0600, Jason Gunthorpe wrote: > On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: > > > Device-tree BSP and in 2014.01 there will be new BSP which just > > generate them directly from the Vivado tools which just target your > > reference design.

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Jason Gunthorpe
On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: > Device-tree BSP and in 2014.01 there will be new BSP which just > generate them directly from the Vivado tools which just target your > reference design. You can connect your custom IP (or Xilinx or 3rd > party) directly to the GIC

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Sören Brinkmann
On Mon, 2014-04-07 at 02:17PM +0200, Mike Looijmans wrote: > On 04/07/2014 07:58 AM, Michal Simek wrote: > >Hi Soren, > > > >On 04/05/2014 01:14 AM, Soren Brinkmann wrote: > >>Convert all Zynq DT files to the dtc preprocessor include syntax. > >>This allows to include header files in the

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Michal Simek
Hi Mike, On 04/07/2014 02:17 PM, Mike Looijmans wrote: > On 04/07/2014 07:58 AM, Michal Simek wrote: >> Hi Soren, >> >> On 04/05/2014 01:14 AM, Soren Brinkmann wrote: >>> Convert all Zynq DT files to the dtc preprocessor include syntax. >>> This allows to include header files in the devicetrees

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Mike Looijmans
On 04/07/2014 07:58 AM, Michal Simek wrote: Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other SoC-types already do. Inspired-by: Steffen Trumtrar

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Mike Looijmans
On 04/07/2014 07:58 AM, Michal Simek wrote: Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other SoC-types already do. Inspired-by: Steffen Trumtrar

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Michal Simek
Hi Mike, On 04/07/2014 02:17 PM, Mike Looijmans wrote: On 04/07/2014 07:58 AM, Michal Simek wrote: Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Sören Brinkmann
On Mon, 2014-04-07 at 02:17PM +0200, Mike Looijmans wrote: On 04/07/2014 07:58 AM, Michal Simek wrote: Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Jason Gunthorpe
On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: Device-tree BSP and in 2014.01 there will be new BSP which just generate them directly from the Vivado tools which just target your reference design. You can connect your custom IP (or Xilinx or 3rd party) directly to the GIC

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-07 Thread Steffen Trumtrar
Hi! On Mon, Apr 07, 2014 at 11:10:12AM -0600, Jason Gunthorpe wrote: On Mon, Apr 07, 2014 at 02:24:07PM +0200, Michal Simek wrote: Device-tree BSP and in 2014.01 there will be new BSP which just generate them directly from the Vivado tools which just target your reference design. You

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-06 Thread Michal Simek
Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: > Convert all Zynq DT files to the dtc preprocessor include syntax. > This allows to include header files in the devicetrees like other > SoC-types already do. > > Inspired-by: Steffen Trumtrar >

Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-06 Thread Michal Simek
Hi Soren, On 04/05/2014 01:14 AM, Soren Brinkmann wrote: Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other SoC-types already do. Inspired-by: Steffen Trumtrar s.trumt...@pengutronix.de

[PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-04 Thread Soren Brinkmann
Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other SoC-types already do. Inspired-by: Steffen Trumtrar (http://www.spinics.net/lists/arm-kernel/msg319832.html) Signed-off-by: Soren Brinkmann --- Changes in v2:

[PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes

2014-04-04 Thread Soren Brinkmann
Convert all Zynq DT files to the dtc preprocessor include syntax. This allows to include header files in the devicetrees like other SoC-types already do. Inspired-by: Steffen Trumtrar s.trumt...@pengutronix.de (http://www.spinics.net/lists/arm-kernel/msg319832.html) Signed-off-by: Soren