Re: [PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

2019-04-11 Thread Alexandre Ghiti
On 04/10/2019 08:27 PM, Kees Cook wrote: On Wed, Apr 10, 2019 at 12:33 AM Alexandre Ghiti wrote: On 04/10/2019 08:59 AM, Christoph Hellwig wrote: On Thu, Apr 04, 2019 at 01:51:25AM -0400, Alexandre Ghiti wrote: - fix the case where stack randomization should not be taken into account.

Re: [PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 12:33 AM Alexandre Ghiti wrote: > > On 04/10/2019 08:59 AM, Christoph Hellwig wrote: > > On Thu, Apr 04, 2019 at 01:51:25AM -0400, Alexandre Ghiti wrote: > >> - fix the case where stack randomization should not be taken into > >>account. > > Hmm. This sounds a bit

Re: [PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

2019-04-10 Thread Alexandre Ghiti
On 04/10/2019 08:59 AM, Christoph Hellwig wrote: On Thu, Apr 04, 2019 at 01:51:25AM -0400, Alexandre Ghiti wrote: - fix the case where stack randomization should not be taken into account. Hmm. This sounds a bit vague. It might be better if something considered a fix is split out to a

Re: [PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

2019-04-10 Thread Christoph Hellwig
On Thu, Apr 04, 2019 at 01:51:25AM -0400, Alexandre Ghiti wrote: > - fix the case where stack randomization should not be taken into > account. Hmm. This sounds a bit vague. It might be better if something considered a fix is split out to a separate patch with a good description. > +config

[PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

2019-04-03 Thread Alexandre Ghiti
arm64 handles top-down mmap layout in a way that can be easily reused by other architectures, so make it available in mm. This commit also takes the opportunity to: - make use of is_compat_task instead of specific arm64 test test_thread_flag(TIF_32BIT), which allows more genericity and is