Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-30 Thread Alex Elder
On 05/29/2014 10:20 PM, Alex Elder wrote: > On 05/23/2014 07:53 PM, Mike Turquette wrote: >> Quoting Alex Elder (2014-05-20 05:52:39) >>> @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) >>> clk = clk_register(NULL, &bcm_clk->hw); >>> if (IS_ERR(clk)) { >>>

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Alex Elder
On 05/23/2014 07:53 PM, Mike Turquette wrote: > Quoting Alex Elder (2014-05-20 05:52:39) >> @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) >> clk = clk_register(NULL, &bcm_clk->hw); >> if (IS_ERR(clk)) { >> pr_err("%s: error registering cl

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 09:53:50) > On 05/29/2014 11:35 AM, Mike Turquette wrote: > > Quoting Alex Elder (2014-05-29 06:26:15) > >> On 05/23/2014 07:53 PM, Mike Turquette wrote: > >>> The above seems like a lot effort to go to. Why not skip all of this and > >>> just implement the prerequisi

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Alex Elder
On 05/29/2014 11:35 AM, Mike Turquette wrote: > Quoting Alex Elder (2014-05-29 06:26:15) >> On 05/23/2014 07:53 PM, Mike Turquette wrote: >>> The above seems like a lot effort to go to. Why not skip all of this and >>> just implement the prerequisite logic in the .enable & .disable >>> callbacks? E

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Mike Turquette
Quoting Alex Elder (2014-05-29 06:26:15) > On 05/23/2014 07:53 PM, Mike Turquette wrote: > > The above seems like a lot effort to go to. Why not skip all of this and > > just implement the prerequisite logic in the .enable & .disable > > callbacks? E.g. your kona clk .enable callback would look lik

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-29 Thread Alex Elder
On 05/23/2014 07:53 PM, Mike Turquette wrote: > Quoting Alex Elder (2014-05-20 05:52:39) >> @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) >> clk = clk_register(NULL, &bcm_clk->hw); >> if (IS_ERR(clk)) { >> pr_err("%s: error registering cl

Re: [PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-23 Thread Mike Turquette
Quoting Alex Elder (2014-05-20 05:52:39) > @@ -743,11 +746,16 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) > clk = clk_register(NULL, &bcm_clk->hw); > if (IS_ERR(clk)) { > pr_err("%s: error registering clock %s (%ld)\n", __func__, > -

[PATCH v2 2/5] clk: bcm281xx: implement prerequisite clocks

2014-05-20 Thread Alex Elder
Allow a clock to specify a "prerequisite" clock. The prerequisite clock must be initialized before the clock that depends on it. A prerequisite clock is defined initially by its name; as that clock gets initialized the name gets replaced with a pointer to its clock structure pointer. In order to