Re: [PATCH v2 2/5] kconfig: refactor Qt package checks for building qconf

2018-05-20 Thread Sam Ravnborg
Hi Masahiro This commit (and the rest of the series) do wonders for the readability of the Makefile - nice work. Some nits below. On Sun, May 20, 2018 at 05:16:50PM +0900, Masahiro Yamada wrote: > Currently, the necessary package checks for building qconf is > surrounded by ifeq

Re: [PATCH v2 2/5] kconfig: refactor Qt package checks for building qconf

2018-05-20 Thread Sam Ravnborg
Hi Masahiro This commit (and the rest of the series) do wonders for the readability of the Makefile - nice work. Some nits below. On Sun, May 20, 2018 at 05:16:50PM +0900, Masahiro Yamada wrote: > Currently, the necessary package checks for building qconf is > surrounded by ifeq

[PATCH v2 2/5] kconfig: refactor Qt package checks for building qconf

2018-05-20 Thread Masahiro Yamada
Currently, the necessary package checks for building qconf is surrounded by ifeq ($(MAKECMDGOALS),xconfig) ... endif. Then, Make will restart when .tmp_qtcheck is generated. To simplify the Makefile, move the scripting to a separate file, and use filechk. The shell script is executed everytime

[PATCH v2 2/5] kconfig: refactor Qt package checks for building qconf

2018-05-20 Thread Masahiro Yamada
Currently, the necessary package checks for building qconf is surrounded by ifeq ($(MAKECMDGOALS),xconfig) ... endif. Then, Make will restart when .tmp_qtcheck is generated. To simplify the Makefile, move the scripting to a separate file, and use filechk. The shell script is executed everytime