Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-15 Thread Andrew Jackson
On 12/12/14 09:37, Lars-Peter Clausen wrote: > On 12/12/2014 10:25 AM, Andrew Jackson wrote: >> From: Andrew Jackson >> >> If the FIFOs aren't flushed, the left/right channels may be swapped: >> this may occur if the FIFOs are not empty when the streams start. >> >> Signed-off-by: Andrew Jackson

Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-15 Thread Andrew Jackson
On 12/12/14 09:37, Lars-Peter Clausen wrote: On 12/12/2014 10:25 AM, Andrew Jackson wrote: From: Andrew Jackson andrew.jack...@arm.com If the FIFOs aren't flushed, the left/right channels may be swapped: this may occur if the FIFOs are not empty when the streams start. Signed-off-by: Andrew

Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Mark Brown
On Fri, Dec 12, 2014 at 10:37:34AM +0100, Lars-Peter Clausen wrote: > This should probably go into the prepare callback. prepare is for example > also called when recovering from a underrun/overrun. Whereas hwparams is > only called during initial setup of the stream. Indeed, that's a better

Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Lars-Peter Clausen
On 12/12/2014 10:25 AM, Andrew Jackson wrote: From: Andrew Jackson If the FIFOs aren't flushed, the left/right channels may be swapped: this may occur if the FIFOs are not empty when the streams start. Signed-off-by: Andrew Jackson --- sound/soc/dwc/designware_i2s.c |2 ++ 1 files

[PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Andrew Jackson
From: Andrew Jackson If the FIFOs aren't flushed, the left/right channels may be swapped: this may occur if the FIFOs are not empty when the streams start. Signed-off-by: Andrew Jackson --- sound/soc/dwc/designware_i2s.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Andrew Jackson
From: Andrew Jackson andrew.jack...@arm.com If the FIFOs aren't flushed, the left/right channels may be swapped: this may occur if the FIFOs are not empty when the streams start. Signed-off-by: Andrew Jackson andrew.jack...@arm.com --- sound/soc/dwc/designware_i2s.c |2 ++ 1 files changed,

Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Lars-Peter Clausen
On 12/12/2014 10:25 AM, Andrew Jackson wrote: From: Andrew Jackson andrew.jack...@arm.com If the FIFOs aren't flushed, the left/right channels may be swapped: this may occur if the FIFOs are not empty when the streams start. Signed-off-by: Andrew Jackson andrew.jack...@arm.com ---

Re: [PATCH v2 2/6] ASoC: dwc: Ensure FIFOs are flushed to prevent channel swap

2014-12-12 Thread Mark Brown
On Fri, Dec 12, 2014 at 10:37:34AM +0100, Lars-Peter Clausen wrote: This should probably go into the prepare callback. prepare is for example also called when recovering from a underrun/overrun. Whereas hwparams is only called during initial setup of the stream. Indeed, that's a better place.