Re: [PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-08-08 Thread Martin Blumenstingl
Hi Kevin, On Thu, Aug 8, 2019 at 4:59 AM Kevin Hilman wrote: > > Martin Blumenstingl writes: > > > Hi Guillaume, > > > > On Mon, Aug 5, 2019 at 2:48 PM guillaume La Roque > > wrote: > >> > >> Hi Martin, > >> > >> again thanks for your review. > > you're welcome - thank you for working on the

Re: [PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-08-07 Thread Kevin Hilman
Martin Blumenstingl writes: > Hi Guillaume, > > On Mon, Aug 5, 2019 at 2:48 PM guillaume La Roque > wrote: >> >> Hi Martin, >> >> again thanks for your review. > you're welcome - thank you for working on the driver :-) > > [...] >> > The IP block has more functionality, which may be added to

Re: [PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-08-06 Thread Martin Blumenstingl
Hi Guillaume, On Mon, Aug 5, 2019 at 2:48 PM guillaume La Roque wrote: > > Hi Martin, > > again thanks for your review. you're welcome - thank you for working on the driver :-) [...] > > The IP block has more functionality, which may be added to this driver > > in the future: > > - reading up

Re: [PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-08-05 Thread guillaume La Roque
Hi Martin, again thanks for your review. On 8/3/19 8:24 PM, Martin Blumenstingl wrote: > Hi Guillaume, > > (I still don't have any experience with the thermal framework, so > below are some general comments) > > On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque > wrote: > I would add a patch

Re: [PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-08-03 Thread Martin Blumenstingl
Hi Guillaume, (I still don't have any experience with the thermal framework, so below are some general comments) On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque wrote: I would add a patch description here: " Amlogic G12A and G12B SoCs integrate two thermal sensors with the same design. One

[PATCH v2 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-07-31 Thread Guillaume La Roque
Signed-off-by: Guillaume La Roque --- drivers/thermal/Kconfig | 11 + drivers/thermal/Makefile | 1 + drivers/thermal/amlogic_thermal.c | 332 ++ 3 files changed, 344 insertions(+) create mode 100644 drivers/thermal/amlogic_thermal.c diff --git