Re: [PATCH v2 2/6] tracing: Change event_enable/disable_read() to verify i_private != NULL

2013-07-29 Thread Steven Rostedt
On Tue, 2013-07-30 at 10:31 +0900, Masami Hiramatsu wrote: > BTW, this still has a cosmetic change, is that OK for Steven? > > > strcat(buf, "\n"); > > - > > return simple_read_from_buffer(ubuf, cnt, ppos, buf, strlen(buf)); > > } > > You mean the above? Don't worry, I removed it ;-)

Re: [PATCH v2 2/6] tracing: Change event_enable/disable_read() to verify i_private != NULL

2013-07-29 Thread Masami Hiramatsu
(2013/07/27 2:25), Oleg Nesterov wrote: > tracing_open_generic_file() is racy, ftrace_event_file can be > already freed by rmdir or trace_remove_event_call(). > > Change event_enable_read() and event_disable_read() to read and > verify "file = i_private" under event_mutex. > > This fixes nothing,

[PATCH v2 2/6] tracing: Change event_enable/disable_read() to verify i_private != NULL

2013-07-26 Thread Oleg Nesterov
tracing_open_generic_file() is racy, ftrace_event_file can be already freed by rmdir or trace_remove_event_call(). Change event_enable_read() and event_disable_read() to read and verify "file = i_private" under event_mutex. This fixes nothing, but now we can change debugfs_remove("enable") caller