Re: [PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs

2021-01-04 Thread Pavel Begunkov
On 04/01/2021 16:37, Matthew Wilcox wrote: > On Sat, Jan 02, 2021 at 03:17:34PM +, Pavel Begunkov wrote: >> --- a/Documentation/filesystems/porting.rst >> +++ b/Documentation/filesystems/porting.rst >> @@ -865,3 +865,10 @@ no matter what. Everything is handled by the caller. >> >>

Re: [PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs

2021-01-04 Thread Matthew Wilcox
On Sat, Jan 02, 2021 at 03:17:34PM +, Pavel Begunkov wrote: > --- a/Documentation/filesystems/porting.rst > +++ b/Documentation/filesystems/porting.rst > @@ -865,3 +865,10 @@ no matter what. Everything is handled by the caller. > > clone_private_mount() returns a longterm mount now, so the

Re: [PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs

2021-01-04 Thread Christoph Hellwig
On Sat, Jan 02, 2021 at 03:17:34PM +, Pavel Begunkov wrote: > zero-length bvec segments are allowed in general, but not handled by bio > and down the block layer so filtered out. This inconsistency may be > confusing and prevent from optimisations. As zero-length segments are > useless and

[PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs

2021-01-02 Thread Pavel Begunkov
zero-length bvec segments are allowed in general, but not handled by bio and down the block layer so filtered out. This inconsistency may be confusing and prevent from optimisations. As zero-length segments are useless and places that were generating them are patched, declare them not allowed.