Re: [PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2019-01-03 Thread Hans de Goede
Hi, On 03-01-19 19:59, Wolfram Sang wrote: I share your desire to have the check for this shared in core code, but I'm afraid that just is not going to work. Okay, so this series is definately not it. Probably the previous one which exposes helpers is not a bad idea after all. Because it is

Re: [PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2019-01-03 Thread Wolfram Sang
> I share your desire to have the check for this shared in core code, > but I'm afraid that just is not going to work. Okay, so this series is definately not it. Probably the previous one which exposes helpers is not a bad idea after all. Because it is ulitmately the driver's decision when to use

Re: [PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2018-12-24 Thread Hans de Goede
Hi, Thank you for this new version. On 22-12-18 21:26, Wolfram Sang wrote: Using the 'is_suspended' flag from the PM core, we now reject new transfers if the parent of the adapter is already marked suspended. I've been running some tests and I'm afraid that those have exposed multiple issues:

[PATCH v2 2/9] i2c: reject new transfers when adapters are suspended

2018-12-22 Thread Wolfram Sang
Using the 'is_suspended' flag from the PM core, we now reject new transfers if the parent of the adapter is already marked suspended. Signed-off-by: Wolfram Sang --- Documentation/i2c/fault-codes | 4 drivers/i2c/i2c-core-base.c | 3 +++ drivers/i2c/i2c-core-smbus.c | 4 3 files cha