Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-08 Thread Tom Zanussi
Hi Steve, On Thu, 2017-09-07 at 18:02 -0400, Steven Rostedt wrote: > On Tue, 5 Sep 2017 16:57:37 -0500 > Tom Zanussi wrote: > > > The tracepoint infrastructure assumes statically-defined tracepoints > > and uses static_keys for tracepoint enablement. In order to

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-08 Thread Tom Zanussi
Hi Steve, On Thu, 2017-09-07 at 18:02 -0400, Steven Rostedt wrote: > On Tue, 5 Sep 2017 16:57:37 -0500 > Tom Zanussi wrote: > > > The tracepoint infrastructure assumes statically-defined tracepoints > > and uses static_keys for tracepoint enablement. In order to define > > tracepoints on the

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-07 Thread Steven Rostedt
On Tue, 5 Sep 2017 16:57:37 -0500 Tom Zanussi wrote: > The tracepoint infrastructure assumes statically-defined tracepoints > and uses static_keys for tracepoint enablement. In order to define > tracepoints on the fly, we need to have a dynamic counterpart. Do we?

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-07 Thread Steven Rostedt
On Tue, 5 Sep 2017 16:57:37 -0500 Tom Zanussi wrote: > The tracepoint infrastructure assumes statically-defined tracepoints > and uses static_keys for tracepoint enablement. In order to define > tracepoints on the fly, we need to have a dynamic counterpart. Do we? I believe the static keys

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Tom Zanussi
Hi Mathieu, On Tue, 2017-09-05 at 23:29 +, Mathieu Desnoyers wrote: > - On Sep 5, 2017, at 5:57 PM, Tom Zanussi tom.zanu...@linux.intel.com > wrote: > > > The tracepoint infrastructure assumes statically-defined tracepoints > > and uses static_keys for tracepoint enablement. In order

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Tom Zanussi
Hi Mathieu, On Tue, 2017-09-05 at 23:29 +, Mathieu Desnoyers wrote: > - On Sep 5, 2017, at 5:57 PM, Tom Zanussi tom.zanu...@linux.intel.com > wrote: > > > The tracepoint infrastructure assumes statically-defined tracepoints > > and uses static_keys for tracepoint enablement. In order

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Mathieu Desnoyers
- On Sep 5, 2017, at 5:57 PM, Tom Zanussi tom.zanu...@linux.intel.com wrote: > The tracepoint infrastructure assumes statically-defined tracepoints > and uses static_keys for tracepoint enablement. In order to define > tracepoints on the fly, we need to have a dynamic counterpart. > > Add a

Re: [PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Mathieu Desnoyers
- On Sep 5, 2017, at 5:57 PM, Tom Zanussi tom.zanu...@linux.intel.com wrote: > The tracepoint infrastructure assumes statically-defined tracepoints > and uses static_keys for tracepoint enablement. In order to define > tracepoints on the fly, we need to have a dynamic counterpart. > > Add a

[PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Tom Zanussi
The tracepoint infrastructure assumes statically-defined tracepoints and uses static_keys for tracepoint enablement. In order to define tracepoints on the fly, we need to have a dynamic counterpart. Add a 'dynamic' flag to struct tracepoint along with accompanying logic for this purpose.

[PATCH v2 25/40] tracing: Add support for dynamic tracepoints

2017-09-05 Thread Tom Zanussi
The tracepoint infrastructure assumes statically-defined tracepoints and uses static_keys for tracepoint enablement. In order to define tracepoints on the fly, we need to have a dynamic counterpart. Add a 'dynamic' flag to struct tracepoint along with accompanying logic for this purpose.