Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-22 Thread Lars Poeschel
On Tue, Sep 22, 2020 at 11:21:21AM +0200, Willy Tarreau wrote: > On Tue, Sep 22, 2020 at 10:49:12AM +0200, Lars Poeschel wrote: > > > I might have got confused, but it looks to me like patches 27 and 28 > > > basically undo patch 26: in 26 you moved code to hd44780 and wrote a > > > fallback, just

Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-22 Thread Willy Tarreau
On Tue, Sep 22, 2020 at 10:49:12AM +0200, Lars Poeschel wrote: > > I might have got confused, but it looks to me like patches 27 and 28 > > basically undo patch 26: in 26 you moved code to hd44780 and wrote a > > fallback, just to later delete that code. > > To be honest: I also got confused by

Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-22 Thread Lars Poeschel
Hi Willy, On Tue, Sep 22, 2020 at 07:22:27AM +0200, Willy Tarreau wrote: > Hi Lars, > > On Mon, Sep 21, 2020 at 04:46:40PM +0200, poesc...@lemonage.de wrote: > > From: Lars Poeschel > > > > We remove the hd44780_clear_fast (display) clear implementation. charlcd > > will fall back to use

Re: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-21 Thread Willy Tarreau
Hi Lars, On Mon, Sep 21, 2020 at 04:46:40PM +0200, poesc...@lemonage.de wrote: > From: Lars Poeschel > > We remove the hd44780_clear_fast (display) clear implementation. charlcd > will fall back to use hd44780_common_clear_display then, which is much > much faster. I might have got confused,

[PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

2020-09-21 Thread poeschel
From: Lars Poeschel We remove the hd44780_clear_fast (display) clear implementation. charlcd will fall back to use hd44780_common_clear_display then, which is much much faster. Signed-off-by: Lars Poeschel --- drivers/auxdisplay/hd44780.c | 14 -- 1 file changed, 14 deletions(-)