Re: [PATCH v2 3/3] arm64: reliable stacktraces

2018-08-20 Thread Julien Thierry
Hi Torsten, On 17/08/18 11:27, Torsten Duwe wrote: This is more an RFC in the original sense: is this basically the correct approach? (as I had to tweak the save_stack API a bit). In particular the code does not detect interrupts and exception frames, and does not yet check whether the code

Re: [PATCH v2 3/3] arm64: reliable stacktraces

2018-08-20 Thread Julien Thierry
Hi Torsten, On 17/08/18 11:27, Torsten Duwe wrote: This is more an RFC in the original sense: is this basically the correct approach? (as I had to tweak the save_stack API a bit). In particular the code does not detect interrupts and exception frames, and does not yet check whether the code

[PATCH v2 3/3] arm64: reliable stacktraces

2018-08-17 Thread Torsten Duwe
This is more an RFC in the original sense: is this basically the correct approach? (as I had to tweak the save_stack API a bit). In particular the code does not detect interrupts and exception frames, and does not yet check whether the code address is valid. The latter check would also have to be

[PATCH v2 3/3] arm64: reliable stacktraces

2018-08-17 Thread Torsten Duwe
This is more an RFC in the original sense: is this basically the correct approach? (as I had to tweak the save_stack API a bit). In particular the code does not detect interrupts and exception frames, and does not yet check whether the code address is valid. The latter check would also have to be