Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Arend Van Spriel
On June 7, 2019 8:06:30 PM Doug Anderson wrote: Hi, On Fri, Jun 7, 2019 at 6:32 AM Arend Van Spriel wrote: Right. I know it supports initial tuning, but I'm not sure about subsequent retuning initiated by the host controller. My evidence says that it supports subsequent tuning. In fact,

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Doug Anderson
Hi, On Fri, Jun 7, 2019 at 6:32 AM Arend Van Spriel wrote: > > On June 7, 2019 2:40:04 PM Adrian Hunter wrote: > > > On 7/06/19 8:12 AM, Arend Van Spriel wrote: > >> On June 6, 2019 11:37:22 PM Doug Anderson wrote: > >>> > >>> In the case of dw_mmc, which I'm most familiar with, we don't have

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Doug Anderson
Hi, On Fri, Jun 7, 2019 at 5:29 AM Adrian Hunter wrote: > > >> @@ -711,8 +720,16 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool > >> on) > >> err_cnt = 0; > >> } > >> /* bail out upon subsequent access errors */ > >> -

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Arend Van Spriel
On June 7, 2019 2:40:04 PM Adrian Hunter wrote: On 7/06/19 8:12 AM, Arend Van Spriel wrote: On June 6, 2019 11:37:22 PM Doug Anderson wrote: In the case of dw_mmc, which I'm most familiar with, we don't have any sort of automated or timed-based retuning.  ...so we'll only re-tune when we

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Adrian Hunter
On 7/06/19 8:12 AM, Arend Van Spriel wrote: > On June 6, 2019 11:37:22 PM Doug Anderson wrote: >> >> In the case of dw_mmc, which I'm most familiar with, we don't have any >> sort of automated or timed-based retuning.  ...so we'll only re-tune >> when we see the CRC error.  If I'm understanding

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-07 Thread Adrian Hunter
On 7/06/19 12:37 AM, Doug Anderson wrote: > Hi, > > On Thu, Jun 6, 2019 at 7:00 AM Adrian Hunter wrote: >> >> On 3/06/19 9:37 PM, Douglas Anderson wrote: >>> There are certain cases, notably when transitioning between sleep and >>> active state, when Broadcom SDIO WiFi cards will produce errors

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-06 Thread Arend Van Spriel
On June 6, 2019 11:37:22 PM Doug Anderson wrote: In the case of dw_mmc, which I'm most familiar with, we don't have any sort of automated or timed-based retuning. ...so we'll only re-tune when we see the CRC error. If I'm understanding things correctly then that for dw_mmc my solution and

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-06 Thread Doug Anderson
Hi, On Thu, Jun 6, 2019 at 7:00 AM Adrian Hunter wrote: > > On 3/06/19 9:37 PM, Douglas Anderson wrote: > > There are certain cases, notably when transitioning between sleep and > > active state, when Broadcom SDIO WiFi cards will produce errors on the > > SDIO bus. This is evident from the

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-06 Thread Adrian Hunter
On 3/06/19 9:37 PM, Douglas Anderson wrote: > There are certain cases, notably when transitioning between sleep and > active state, when Broadcom SDIO WiFi cards will produce errors on the > SDIO bus. This is evident from the source code where you can see that > we try commands in a loop until we

[PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-03 Thread Douglas Anderson
There are certain cases, notably when transitioning between sleep and active state, when Broadcom SDIO WiFi cards will produce errors on the SDIO bus. This is evident from the source code where you can see that we try commands in a loop until we either get success or we've tried too many times.