Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-27 Thread Baolin Wang
On 27 February 2018 at 23:54, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 4:35 AM, Baolin Wang wrote: >> On 26 February 2018 at 20:02, Andy Shevchenko >> wrote: >>> On Mon, Feb 26, 2018 at 5:01 AM, Baolin Wang wrote: On 25 February 2018 at 20:19, Andy Shevchenko wrote: > >

Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 4:35 AM, Baolin Wang wrote: > On 26 February 2018 at 20:02, Andy Shevchenko > wrote: >> On Mon, Feb 26, 2018 at 5:01 AM, Baolin Wang wrote: >>> On 25 February 2018 at 20:19, Andy Shevchenko >>> wrote: > + for (n = 0; n < chip->ngpio; n++) { > +

Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-26 Thread Baolin Wang
On 26 February 2018 at 20:02, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 5:01 AM, Baolin Wang wrote: >> On 25 February 2018 at 20:19, Andy Shevchenko >> wrote: >>> On Sat, Feb 24, 2018 at 12:44 PM, Baolin Wang >>> wrote: > +static int sprd_pmic_eic_direction_input(struct gpio_chip

Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 5:01 AM, Baolin Wang wrote: > On 25 February 2018 at 20:19, Andy Shevchenko > wrote: >> On Sat, Feb 24, 2018 at 12:44 PM, Baolin Wang wrote: >>> +static int sprd_pmic_eic_direction_input(struct gpio_chip *chip, >>> +unsigned int o

Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-25 Thread Baolin Wang
Hi Andy, On 25 February 2018 at 20:19, Andy Shevchenko wrote: > On Sat, Feb 24, 2018 at 12:44 PM, Baolin Wang wrote: >> The Spreadtrum PMIC EIC controller contains only one bank of debounce EIC, >> and this bank contains 16 EICs. Each EIC can only be used as input mode, >> as well as supporting

Re: [PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-25 Thread Andy Shevchenko
On Sat, Feb 24, 2018 at 12:44 PM, Baolin Wang wrote: > The Spreadtrum PMIC EIC controller contains only one bank of debounce EIC, > and this bank contains 16 EICs. Each EIC can only be used as input mode, > as well as supporting the debounce and the capability to trigger interrupts > when detectin

[PATCH v2 3/3] gpio: Add Spreadtrum PMIC EIC driver support

2018-02-24 Thread Baolin Wang
The Spreadtrum PMIC EIC controller contains only one bank of debounce EIC, and this bank contains 16 EICs. Each EIC can only be used as input mode, as well as supporting the debounce and the capability to trigger interrupts when detecting input signals. Signed-off-by: Baolin Wang --- Changes sinc