Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-27 Thread Andy Shevchenko
On Tue, 2013-11-26 at 10:38 +0100, Linus Walleij wrote: > On Wed, Nov 20, 2013 at 3:31 PM, Andy Shevchenko > wrote: > > > Instead of custom implementation of the SFI GPIO API let's use one provided > > by > > gpiolib. > > > > Signed-off-by: Andy Shevchenko > > So is it possible to move this

Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-27 Thread Andy Shevchenko
On Tue, 2013-11-26 at 10:38 +0100, Linus Walleij wrote: On Wed, Nov 20, 2013 at 3:31 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Instead of custom implementation of the SFI GPIO API let's use one provided by gpiolib. Signed-off-by: Andy Shevchenko

Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-26 Thread Linus Walleij
On Wed, Nov 20, 2013 at 3:31 PM, Andy Shevchenko wrote: > Instead of custom implementation of the SFI GPIO API let's use one provided by > gpiolib. > > Signed-off-by: Andy Shevchenko So is it possible to move this to just do gpiod_get() from the drivers and abstract away SFI altogether as

Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-26 Thread Linus Walleij
On Wed, Nov 20, 2013 at 3:31 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Instead of custom implementation of the SFI GPIO API let's use one provided by gpiolib. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com So is it possible to move this to just do

Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-20 Thread David Cohen
Hi Andy, Thanks for the patch. On 11/20/2013 06:31 AM, Andy Shevchenko wrote: > Instead of custom implementation of the SFI GPIO API let's use one provided by > gpiolib. > > Signed-off-by: Andy Shevchenko Acked-by: David Cohen > --- > arch/x86/include/asm/intel-mid.h | 1

[PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-20 Thread Andy Shevchenko
Instead of custom implementation of the SFI GPIO API let's use one provided by gpiolib. Signed-off-by: Andy Shevchenko --- arch/x86/include/asm/intel-mid.h | 1 - .../intel-mid/device_libs/platform_emc1403.c | 8 ++-- .../intel-mid/device_libs/platform_gpio_keys.c

[PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-20 Thread Andy Shevchenko
Instead of custom implementation of the SFI GPIO API let's use one provided by gpiolib. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- arch/x86/include/asm/intel-mid.h | 1 - .../intel-mid/device_libs/platform_emc1403.c | 8 ++--

Re: [PATCH v2 3/3] intel_mid: switch to use SFI GPIO API

2013-11-20 Thread David Cohen
Hi Andy, Thanks for the patch. On 11/20/2013 06:31 AM, Andy Shevchenko wrote: Instead of custom implementation of the SFI GPIO API let's use one provided by gpiolib. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: David Cohen david.a.co...@linux.intel.com ---