Re: [PATCH v2 3/3] kmemleak: change some global variables to int

2014-03-21 Thread Catalin Marinas
On Mon, Mar 17, 2014 at 04:09:04AM +, Li Zefan wrote: > They don't have to be atomic_t, because they are simple boolean > toggles. > > Signed-off-by: Li Zefan A reason for which I had atomic_t was to avoid compiler optimisations but I don't immediately see how it could go wrong. Assuming

Re: [PATCH v2 3/3] kmemleak: change some global variables to int

2014-03-21 Thread Catalin Marinas
On Mon, Mar 17, 2014 at 04:09:04AM +, Li Zefan wrote: They don't have to be atomic_t, because they are simple boolean toggles. Signed-off-by: Li Zefan lize...@huawei.com A reason for which I had atomic_t was to avoid compiler optimisations but I don't immediately see how it could go

[PATCH v2 3/3] kmemleak: change some global variables to int

2014-03-16 Thread Li Zefan
They don't have to be atomic_t, because they are simple boolean toggles. Signed-off-by: Li Zefan --- mm/kmemleak.c | 78 +-- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index

[PATCH v2 3/3] kmemleak: change some global variables to int

2014-03-16 Thread Li Zefan
They don't have to be atomic_t, because they are simple boolean toggles. Signed-off-by: Li Zefan lize...@huawei.com --- mm/kmemleak.c | 78 +-- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c