Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:22), Minchan Kim wrote: [..] >> I have a patchset with my nitpicks addressed and fix-ups for missing >> gfps. >> Do you mind me to send it out? >Hey Sergey >I am on vacation and outside now. so if you resend with things you pointed Oh, lovely, have a good

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:19), Sergey Senozhatsky wrote: [..] > > > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t > > > flags) > > > { > > > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > > > +

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:05), Sergey Senozhatsky wrote: > Minchan Kim wrote: > [..] > > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t flags) > > { > > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > > +

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hello, Minchan Kim wrote: [..] > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t flags) > { > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > + __GFP_NOWARN|__GFP_NOMEMALLOC); and it seems that after 3/3 (v2)

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hello, Minchan Kim wrote: [..] > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t flags) > { > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > + __GFP_NOWARN|__GFP_NOMEMALLOC); and it seems that after 3/3 (v2)

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:05), Sergey Senozhatsky wrote: > Minchan Kim wrote: > [..] > > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t flags) > > { > > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > > +

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:22), Minchan Kim wrote: [..] >> I have a patchset with my nitpicks addressed and fix-ups for missing >> gfps. >> Do you mind me to send it out? >Hey Sergey >I am on vacation and outside now. so if you resend with things you pointed Oh, lovely, have a good

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/27/15 11:19), Sergey Senozhatsky wrote: [..] > > > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t > > > flags) > > > { > > > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > > > +

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

[sorry, ended up screwing up Message-Id in In-Reply-To! resending] -- Minchan Kim wrote: [..] > > Aha, I see. I don't mind to send it to -stable (with __GFP_HIGHMEM fix > > up). Hello Minchan, Sorry for not replying sooner. >

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Minchan Kim wrote: [..] > > Aha, I see. I don't mind to send it to -stable (with __GFP_HIGHMEM fix > > up). Hello Minchan, Sorry for not replying sooner. > Sure. > Can I add your acked-by for [2/3] and [3/3]? > > And I will keep order and add stable mark in [2/3]. yes. a) + __GFP_HIGHMEM

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On Thu, Nov 26, 2015 at 12:04:49AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (11/25/15 22:50), Minchan Kim wrote: > [..] > > > I think that applying 3/3 before 2/3 will be a simpler (and probably a > > > better) > > > thing to do. We fitst extend zcomp interface and pass flags (without

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hello, On (11/25/15 22:50), Minchan Kim wrote: [..] > > I think that applying 3/3 before 2/3 will be a simpler (and probably a > > better) > > thing to do. We fitst extend zcomp interface and pass flags (without any > > functional change) and then extend the flags and introduce vmalloc fallback.

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hi Sergey, On Wed, Nov 25, 2015 at 09:46:47PM +0900, Sergey Senozhatsky wrote: > On (11/25/15 14:51), Minchan Kim wrote: > [..] > > + /* > > +* This function could be called in swapout/fs write path > > +* so we couldn't use GFP_FS|IO. And it assumes we already >

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/25/15 14:51), Minchan Kim wrote: [..] > + /* > + * This function could be called in swapout/fs write path > + * so we couldn't use GFP_FS|IO. And it assumes we already > + * have at least one stream in zram initialization so we > +

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On Thu, Nov 26, 2015 at 12:04:49AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (11/25/15 22:50), Minchan Kim wrote: > [..] > > > I think that applying 3/3 before 2/3 will be a simpler (and probably a > > > better) > > > thing to do. We fitst extend zcomp interface and pass flags (without

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

[sorry, ended up screwing up Message-Id in In-Reply-To! resending] -- Minchan Kim wrote: [..] > > Aha, I see. I don't mind to send it to -stable (with __GFP_HIGHMEM fix > > up). Hello Minchan, Sorry for not

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hello, On (11/25/15 22:50), Minchan Kim wrote: [..] > > I think that applying 3/3 before 2/3 will be a simpler (and probably a > > better) > > thing to do. We fitst extend zcomp interface and pass flags (without any > > functional change) and then extend the flags and introduce vmalloc fallback.

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Minchan Kim wrote: [..] > > Aha, I see. I don't mind to send it to -stable (with __GFP_HIGHMEM fix > > up). Hello Minchan, Sorry for not replying sooner. > Sure. > Can I add your acked-by for [2/3] and [3/3]? > > And I will keep order and add stable mark in [2/3]. yes.

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Hi Sergey, On Wed, Nov 25, 2015 at 09:46:47PM +0900, Sergey Senozhatsky wrote: > On (11/25/15 14:51), Minchan Kim wrote: > [..] > > + /* > > +* This function could be called in swapout/fs write path > > +* so we couldn't use GFP_FS|IO. And it assumes we already >

Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

On (11/25/15 14:51), Minchan Kim wrote: [..] > + /* > + * This function could be called in swapout/fs write path > + * so we couldn't use GFP_FS|IO. And it assumes we already > + * have at least one stream in zram initialization so we > +

[PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Each zcomp backend uses own gfp flag but it's pointless because the context they could be called is driven by upper layer(ie, zcomp frontend). As well, zcomp frondend could call them in different context. One context(ie, zram init part) is it should be better to make sure successful allocation

[PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend

Each zcomp backend uses own gfp flag but it's pointless because the context they could be called is driven by upper layer(ie, zcomp frontend). As well, zcomp frondend could call them in different context. One context(ie, zram init part) is it should be better to make sure successful allocation