Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-12-01 Thread Fāng-ruì Sòng
On 2020-12-01, Segher Boessenkool wrote: On Tue, Dec 01, 2020 at 12:38:16PM +0900, Masahiro Yamada wrote: > We can bump -Wa,-gdwarf-2 to -Wa,-gdwarf-3 since GNU actually emits > DWARF v3 DW_AT_ranges (see > https://sourceware.org/bugzilla/show_bug.cgi?id=26850 ) > This can avoid the `warning:

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-12-01 Thread Segher Boessenkool
On Tue, Dec 01, 2020 at 12:38:16PM +0900, Masahiro Yamada wrote: > > We can bump -Wa,-gdwarf-2 to -Wa,-gdwarf-3 since GNU actually emits > > DWARF v3 DW_AT_ranges (see > > https://sourceware.org/bugzilla/show_bug.cgi?id=26850 ) > > This can avoid the `warning: DWARF2 only supports one section per

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-30 Thread Masahiro Yamada
On Tue, Dec 1, 2020 at 5:45 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Mon, Nov 30, 2020 at 10:05 AM Masahiro Yamada wrote: > > > > On Wed, Nov 4, 2020 at 9:53 AM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-30 Thread Masahiro Yamada
On Tue, Dec 1, 2020 at 5:27 AM 'Fāng-ruì Sòng' via Clang Built Linux wrote: > > On Mon, Nov 30, 2020 at 10:05 AM Masahiro Yamada wrote: > > > > On Wed, Nov 4, 2020 at 9:53 AM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-30 Thread Nick Desaulniers
On Mon, Nov 30, 2020 at 10:05 AM Masahiro Yamada wrote: > > On Wed, Nov 4, 2020 at 9:53 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > >

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-30 Thread Fāng-ruì Sòng
On Mon, Nov 30, 2020 at 10:05 AM Masahiro Yamada wrote: > > On Wed, Nov 4, 2020 at 9:53 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > >

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-30 Thread Masahiro Yamada
On Wed, Nov 4, 2020 at 9:53 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with existing configs, and makes adding

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-24 Thread Segher Boessenkool
On Tue, Nov 24, 2020 at 11:56:02AM -0500, Arvind Sankar wrote: > On Mon, Nov 23, 2020 at 06:33:57PM -0600, Segher Boessenkool wrote: > > On Mon, Nov 23, 2020 at 06:22:10PM -0500, Arvind Sankar wrote: > > > Btw, is -gsplit-dwarf at all useful for assembler files? > > > > If you invoke the

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-24 Thread Arvind Sankar
On Mon, Nov 23, 2020 at 06:33:57PM -0600, Segher Boessenkool wrote: > On Mon, Nov 23, 2020 at 06:22:10PM -0500, Arvind Sankar wrote: > > Btw, is -gsplit-dwarf at all useful for assembler files? > > If you invoke the assembler via the compiler, with that flag it still > creates separate .o and

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-23 Thread Segher Boessenkool
On Mon, Nov 23, 2020 at 06:22:10PM -0500, Arvind Sankar wrote: > Btw, is -gsplit-dwarf at all useful for assembler files? If you invoke the assembler via the compiler, with that flag it still creates separate .o and .dwo files (via objcopy invocations as usual). Whether that is useful depends on

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-23 Thread Arvind Sankar
On Tue, Nov 03, 2020 at 04:53:42PM -0800, Nick Desaulniers wrote: > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with existing configs, and makes adding > future

Re: [PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-04 Thread kernel test robot
Hi Nick, I love your patch! Yet something to improve: [auto build test ERROR on kbuild/for-next] [also build test ERROR on asm-generic/master linus/master v5.10-rc2 next-20201104] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v2 3/4] Kbuild: make DWARF version a choice

2020-11-03 Thread Nick Desaulniers
Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a way that's forward compatible with existing configs, and makes adding future versions more straightforward. Suggested-by: Fangrui Song Suggested-by: