Re: [PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread David Rientjes
On Wed, 4 Dec 2013, Oleg Nesterov wrote: > At least out_of_memory() calls has_intersects_mems_allowed() > without even rcu_read_lock(), this is obviously buggy. > > Add the necessary rcu_read_lock(). This means that we can not > simply return from the loop, we need "bool ret" and "break". > >

Re: [PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread Michal Hocko
On Wed 04-12-13 14:04:16, Oleg Nesterov wrote: > At least out_of_memory() calls has_intersects_mems_allowed() > without even rcu_read_lock(), this is obviously buggy. > > Add the necessary rcu_read_lock(). This means that we can not > simply return from the loop, we need "bool ret" and "break". >

[PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread Oleg Nesterov
At least out_of_memory() calls has_intersects_mems_allowed() without even rcu_read_lock(), this is obviously buggy. Add the necessary rcu_read_lock(). This means that we can not simply return from the loop, we need "bool ret" and "break". While at it, swap the names of task_struct's (the

[PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread Oleg Nesterov
At least out_of_memory() calls has_intersects_mems_allowed() without even rcu_read_lock(), this is obviously buggy. Add the necessary rcu_read_lock(). This means that we can not simply return from the loop, we need bool ret and break. While at it, swap the names of task_struct's (the argument

Re: [PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread Michal Hocko
On Wed 04-12-13 14:04:16, Oleg Nesterov wrote: At least out_of_memory() calls has_intersects_mems_allowed() without even rcu_read_lock(), this is obviously buggy. Add the necessary rcu_read_lock(). This means that we can not simply return from the loop, we need bool ret and break. While

Re: [PATCH v2 3/4] oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

2013-12-04 Thread David Rientjes
On Wed, 4 Dec 2013, Oleg Nesterov wrote: At least out_of_memory() calls has_intersects_mems_allowed() without even rcu_read_lock(), this is obviously buggy. Add the necessary rcu_read_lock(). This means that we can not simply return from the loop, we need bool ret and break. While at it,