Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-07-13 Thread Stefan Agner
On 13.07.2018 01:01, Russell King - ARM Linux wrote: > On Thu, Jul 12, 2018 at 03:43:10PM -0700, Kees Cook wrote: >> On Tue, Apr 17, 2018 at 1:11 AM, Thierry Reding wrote: >> > On Mon, Apr 16, 2018 at 08:21:09PM +0200, Stefan Agner wrote: >> >> On 16.04.2018 18:08, Stephen Warren wrote: >> >> > On

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-07-12 Thread Russell King - ARM Linux
On Thu, Jul 12, 2018 at 03:43:10PM -0700, Kees Cook wrote: > On Tue, Apr 17, 2018 at 1:11 AM, Thierry Reding wrote: > > On Mon, Apr 16, 2018 at 08:21:09PM +0200, Stefan Agner wrote: > >> On 16.04.2018 18:08, Stephen Warren wrote: > >> > On 04/16/2018 09:56 AM, Stefan Agner wrote: > >> >> On 27.03.

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-07-12 Thread Russell King - ARM Linux
On Sun, Mar 25, 2018 at 08:09:56PM +0200, Stefan Agner wrote: > As documented in GCC naked functions should only use Basic asm > syntax. The Extended asm or mixture of Basic asm and "C" code is > not guaranteed. Currently this works because it was hard coded > to follow and check GCC behavior for a

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-07-12 Thread Kees Cook
On Tue, Apr 17, 2018 at 1:11 AM, Thierry Reding wrote: > On Mon, Apr 16, 2018 at 08:21:09PM +0200, Stefan Agner wrote: >> On 16.04.2018 18:08, Stephen Warren wrote: >> > On 04/16/2018 09:56 AM, Stefan Agner wrote: >> >> On 27.03.2018 14:16, Dmitry Osipenko wrote: >> >>> On 27.03.2018 14:54, Robin

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-06-26 Thread Stefan Agner
On 17.04.2018 10:11, Thierry Reding wrote: > On Mon, Apr 16, 2018 at 08:21:09PM +0200, Stefan Agner wrote: >> On 16.04.2018 18:08, Stephen Warren wrote: >> > On 04/16/2018 09:56 AM, Stefan Agner wrote: >> >> On 27.03.2018 14:16, Dmitry Osipenko wrote: >> >>> On 27.03.2018 14:54, Robin Murphy wrote:

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-05-19 Thread Dmitry Osipenko
On 16.04.2018 21:21, Stefan Agner wrote: > On 16.04.2018 18:08, Stephen Warren wrote: >> On 04/16/2018 09:56 AM, Stefan Agner wrote: >>> On 27.03.2018 14:16, Dmitry Osipenko wrote: On 27.03.2018 14:54, Robin Murphy wrote: > On 26/03/18 22:20, Dmitry Osipenko wrote: >> On 25.03.2018 21:

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-04-17 Thread Thierry Reding
On Mon, Apr 16, 2018 at 08:21:09PM +0200, Stefan Agner wrote: > On 16.04.2018 18:08, Stephen Warren wrote: > > On 04/16/2018 09:56 AM, Stefan Agner wrote: > >> On 27.03.2018 14:16, Dmitry Osipenko wrote: > >>> On 27.03.2018 14:54, Robin Murphy wrote: > On 26/03/18 22:20, Dmitry Osipenko wrote:

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-04-16 Thread Stefan Agner
On 16.04.2018 18:08, Stephen Warren wrote: > On 04/16/2018 09:56 AM, Stefan Agner wrote: >> On 27.03.2018 14:16, Dmitry Osipenko wrote: >>> On 27.03.2018 14:54, Robin Murphy wrote: On 26/03/18 22:20, Dmitry Osipenko wrote: > On 25.03.2018 21:09, Stefan Agner wrote: >> As documented in

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-04-16 Thread Stephen Warren
On 04/16/2018 09:56 AM, Stefan Agner wrote: On 27.03.2018 14:16, Dmitry Osipenko wrote: On 27.03.2018 14:54, Robin Murphy wrote: On 26/03/18 22:20, Dmitry Osipenko wrote: On 25.03.2018 21:09, Stefan Agner wrote: As documented in GCC naked functions should only use Basic asm syntax. The Extend

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-04-16 Thread Stefan Agner
On 27.03.2018 14:16, Dmitry Osipenko wrote: > On 27.03.2018 14:54, Robin Murphy wrote: >> On 26/03/18 22:20, Dmitry Osipenko wrote: >>> On 25.03.2018 21:09, Stefan Agner wrote: As documented in GCC naked functions should only use Basic asm syntax. The Extended asm or mixture of Basic asm

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-03-27 Thread Dmitry Osipenko
On 27.03.2018 14:54, Robin Murphy wrote: > On 26/03/18 22:20, Dmitry Osipenko wrote: >> On 25.03.2018 21:09, Stefan Agner wrote: >>> As documented in GCC naked functions should only use Basic asm >>> syntax. The Extended asm or mixture of Basic asm and "C" code is >>> not guaranteed. Currently this

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-03-27 Thread Robin Murphy
On 26/03/18 22:20, Dmitry Osipenko wrote: On 25.03.2018 21:09, Stefan Agner wrote: As documented in GCC naked functions should only use Basic asm syntax. The Extended asm or mixture of Basic asm and "C" code is not guaranteed. Currently this works because it was hard coded to follow and check GC

Re: [PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-03-26 Thread Dmitry Osipenko
On 25.03.2018 21:09, Stefan Agner wrote: > As documented in GCC naked functions should only use Basic asm > syntax. The Extended asm or mixture of Basic asm and "C" code is > not guaranteed. Currently this works because it was hard coded > to follow and check GCC behavior for arguments and register

[PATCH v2 3/6] ARM: trusted_foundations: do not use naked function

2018-03-25 Thread Stefan Agner
As documented in GCC naked functions should only use Basic asm syntax. The Extended asm or mixture of Basic asm and "C" code is not guaranteed. Currently this works because it was hard coded to follow and check GCC behavior for arguments and register placement. Furthermore with clang using paramet