Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

Hi, On Wed, Jul 5, 2017 at 6:41 AM, Patrick Bellasi wrote: [..] > >> But what about clearing the sched-class's flag from .pick_next_task() >> callback >> when they return NULL ? >> >> What about something like this instead (completely untested), with which we >> don't

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

Hi, On Wed, Jul 5, 2017 at 6:41 AM, Patrick Bellasi wrote: [..] > >> But what about clearing the sched-class's flag from .pick_next_task() >> callback >> when they return NULL ? >> >> What about something like this instead (completely untested), with which we >> don't need the 2/3 patch as

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

On 05-07-17, 14:41, Patrick Bellasi wrote: > On 05-Jul 11:31, Viresh Kumar wrote: > Just had a fast check but I think something like that can work. > We had an internal discussion with Brendan (in CC now) which had a > similar proposal. > > Main counter arguments for me was: > 1. we wanna to

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

On 05-07-17, 14:41, Patrick Bellasi wrote: > On 05-Jul 11:31, Viresh Kumar wrote: > Just had a fast check but I think something like that can work. > We had an internal discussion with Brendan (in CC now) which had a > similar proposal. > > Main counter arguments for me was: > 1. we wanna to

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

[+Brendan] On 05-Jul 11:31, Viresh Kumar wrote: > On 04-07-17, 18:34, Patrick Bellasi wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > > index 004ae18..98704d8 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

[+Brendan] On 05-Jul 11:31, Viresh Kumar wrote: > On 04-07-17, 18:34, Patrick Bellasi wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > > index 004ae18..98704d8 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

On 04-07-17, 18:34, Patrick Bellasi wrote: > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index 004ae18..98704d8 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -216,6 +216,7 @@ static void

Re: [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

On 04-07-17, 18:34, Patrick Bellasi wrote: > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index 004ae18..98704d8 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -216,6 +216,7 @@ static void

[PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

The policy in use for RT/DL tasks sets the maximum frequency when a task in these classes calls for a cpufreq_update_this_cpu(). However, the current implementation might cause a frequency drop while a RT/DL task is still running, just because for example a FAIR task wakes up and it's enqueued in

[PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks

The policy in use for RT/DL tasks sets the maximum frequency when a task in these classes calls for a cpufreq_update_this_cpu(). However, the current implementation might cause a frequency drop while a RT/DL task is still running, just because for example a FAIR task wakes up and it's enqueued in