Re: [PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Hans Verkuil
On 11/03/2021 23:19, Ricardo Ribalda wrote: > The device is doing something unspected with the control. Either because > the protocol is not properly implemented or there has been a HW error. > > Fixes v4l2-compliance: > > Control ioctls (Input 0): > fail:

Re: [PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda Delgado
Hi Laurent On Fri, Mar 12, 2021 at 12:30 AM Laurent Pinchart wrote: > > Hi Ricardo, > > On Thu, Mar 11, 2021 at 11:59:27PM +0100, Ricardo Ribalda Delgado wrote: > > On Thu, Mar 11, 2021 at 11:53 PM Laurent Pinchart wrote: > > > On Thu, Mar 11, 2021 at 11:19:43PM +0100, Ricardo Ribalda wrote: > >

Re: [PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Laurent Pinchart
Hi Ricardo, On Thu, Mar 11, 2021 at 11:59:27PM +0100, Ricardo Ribalda Delgado wrote: > On Thu, Mar 11, 2021 at 11:53 PM Laurent Pinchart wrote: > > On Thu, Mar 11, 2021 at 11:19:43PM +0100, Ricardo Ribalda wrote: > > > The device is doing something unspected with the control. Either because > > >

Re: [PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda Delgado
Hi Laurent On Thu, Mar 11, 2021 at 11:53 PM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. Thank you :) > > On Thu, Mar 11, 2021 at 11:19:43PM +0100, Ricardo Ribalda wrote: > > The device is doing something unspected with the control. Either because > > the protocol is not

Re: [PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Thu, Mar 11, 2021 at 11:19:43PM +0100, Ricardo Ribalda wrote: > The device is doing something unspected with the control. Either because > the protocol is not properly implemented or there has been a HW error. > > Fixes v4l2-compliance: > > Control

[PATCH v2 3/6] media: uvcvideo: Return -EIO for control errors

2021-03-11 Thread Ricardo Ribalda
The device is doing something unspected with the control. Either because the protocol is not properly implemented or there has been a HW error. Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(448): s_ctrl returned an error (22) test