Re: [PATCH v2 3/7] mm/swap: Use local_lock for protection

2020-05-25 Thread Sebastian Andrzej Siewior
On 2020-05-25 08:44:36 [+0200], Ingo Molnar wrote: > s/lru_rotate_pvecs > /lru_rotate_pvec > > it's a single pagevec, using plural is confusing when reading the > code. right. It had the _pvecs from the beginning so I assumed it is because it is per-CPU. With all you suggestions I'm at: diff

Re: [PATCH v2 3/7] mm/swap: Use local_lock for protection

2020-05-25 Thread Ingo Molnar
* Sebastian Andrzej Siewior wrote: > From: Ingo Molnar > > The various struct pagevec per CPU variables are protected by disabling > either preemption or interrupts across the critical sections. Inside > these sections spinlocks have to be acquired. > diff --git a/mm/swap.c b/mm/swap.c >

[PATCH v2 3/7] mm/swap: Use local_lock for protection

2020-05-24 Thread Sebastian Andrzej Siewior
From: Ingo Molnar The various struct pagevec per CPU variables are protected by disabling either preemption or interrupts across the critical sections. Inside these sections spinlocks have to be acquired. These spinlocks are regular spinlock_t types which are converted to "sleeping" spinlocks