Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-07 Thread Namhyung Kim
Hi Jiri, On Sat, Mar 05, 2016 at 07:17:22PM +0100, Jiri Olsa wrote: > On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct > > hists *hists, > > struct

Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-07 Thread Namhyung Kim
Hi Jiri, On Sat, Mar 05, 2016 at 07:17:22PM +0100, Jiri Olsa wrote: > On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct > > hists *hists, > > struct

Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-05 Thread Jiri Olsa
On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote: SNIP > @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct hists > *hists, >struct hist_entry *he) > { > struct perf_hpp_fmt *fmt; > + struct perf_hpp_list_node

Re: [PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-05 Thread Jiri Olsa
On Fri, Mar 04, 2016 at 11:59:37PM +0900, Namhyung Kim wrote: SNIP > @@ -1150,20 +1159,29 @@ static int hists__hierarchy_insert_entry(struct hists > *hists, >struct hist_entry *he) > { > struct perf_hpp_fmt *fmt; > + struct perf_hpp_list_node

[PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-04 Thread Namhyung Kim
Now each hists has its own hpp lists in hierarchy. So instead of having a pointer to a single perf_hpp_fmt in a hist entry, make it point the hpp_list for its level. This will be used to support multiple sort keys in a single hierarchy level. Signed-off-by: Namhyung Kim

[PATCH v2 3/8] perf tools: Use own hpp_list for hierarchy mode

2016-03-04 Thread Namhyung Kim
Now each hists has its own hpp lists in hierarchy. So instead of having a pointer to a single perf_hpp_fmt in a hist entry, make it point the hpp_list for its level. This will be used to support multiple sort keys in a single hierarchy level. Signed-off-by: Namhyung Kim ---