Re: [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-08 Thread Tom Zanussi
On Fri, 2017-09-08 at 15:25 -0400, Steven Rostedt wrote: > On Tue, 5 Sep 2017 16:57:46 -0500 > Tom Zanussi wrote: > > > +static char *hist_err_str; > > +static char *last_hist_cmd; > > + > > +static int hist_err_alloc(void) > > +{ > > + int ret = 0; > > + > > +

Re: [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-08 Thread Tom Zanussi
On Fri, 2017-09-08 at 15:25 -0400, Steven Rostedt wrote: > On Tue, 5 Sep 2017 16:57:46 -0500 > Tom Zanussi wrote: > > > +static char *hist_err_str; > > +static char *last_hist_cmd; > > + > > +static int hist_err_alloc(void) > > +{ > > + int ret = 0; > > + > > + last_hist_cmd =

Re: [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-08 Thread Steven Rostedt
On Tue, 5 Sep 2017 16:57:46 -0500 Tom Zanussi wrote: > +static char *hist_err_str; > +static char *last_hist_cmd; > + > +static int hist_err_alloc(void) > +{ > + int ret = 0; > + > + last_hist_cmd = kzalloc(MAX_FILTER_STR_VAL, GFP_KERNEL); > + if

Re: [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-08 Thread Steven Rostedt
On Tue, 5 Sep 2017 16:57:46 -0500 Tom Zanussi wrote: > +static char *hist_err_str; > +static char *last_hist_cmd; > + > +static int hist_err_alloc(void) > +{ > + int ret = 0; > + > + last_hist_cmd = kzalloc(MAX_FILTER_STR_VAL, GFP_KERNEL); > + if (!last_hist_cmd) > +

[PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-05 Thread Tom Zanussi
With the addition of variables and actions, it's become necessary to provide more detailed error information to users about syntax errors. Add a 'last error' facility accessible via the erroring event's 'hist' file. Reading the hist file after an error will display more detailed information

[PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers

2017-09-05 Thread Tom Zanussi
With the addition of variables and actions, it's become necessary to provide more detailed error information to users about syntax errors. Add a 'last error' facility accessible via the erroring event's 'hist' file. Reading the hist file after an error will display more detailed information