Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-11 Thread Jianxin Pan
Hi Martin, On 2019/9/10 1:24, Martin Blumenstingl wrote: > Hi Jianxin, > > On Mon, Sep 9, 2019 at 2:03 PM Jianxin Pan wrote: >> >> Hi Martin, >> >> On 2019/9/7 23:02, Martin Blumenstingl wrote: >>> Hi Jianxin, >>> >>> On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: >>> [...] > also I'm a

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-09 Thread Martin Blumenstingl
Hi Jianxin, On Mon, Sep 9, 2019 at 2:03 PM Jianxin Pan wrote: > > Hi Martin, > > On 2019/9/7 23:02, Martin Blumenstingl wrote: > > Hi Jianxin, > > > > On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: > > [...] > >>> also I'm a bit surprised to see no busses (like aobus, cbus, periphs, > >>>

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-09 Thread Jianxin Pan
Hi Jerome, On 2019/9/9 19:36, Jerome Brunet wrote: > > On Sat 07 Sep 2019 at 17:02, Martin Blumenstingl wrote: > >> Hi Jianxin, >> >> On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: >> [...] also I'm a bit surprised to see no busses (like aobus, cbus, periphs, ...) here

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-09 Thread Jianxin Pan
Hi Martin, On 2019/9/7 23:02, Martin Blumenstingl wrote: > Hi Jianxin, > > On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: > [...] >>> also I'm a bit surprised to see no busses (like aobus, cbus, periphs, ...) >>> here >>> aren't there any busses defined in the A1 SoC implementation or are

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-09 Thread Jerome Brunet
On Sat 07 Sep 2019 at 17:02, Martin Blumenstingl wrote: > Hi Jianxin, > > On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: > [...] >> > also I'm a bit surprised to see no busses (like aobus, cbus, periphs, ...) >> > here >> > aren't there any busses defined in the A1 SoC implementation or

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-07 Thread Martin Blumenstingl
Hi Jianxin, On Fri, Sep 6, 2019 at 7:58 AM Jianxin Pan wrote: [...] > > also I'm a bit surprised to see no busses (like aobus, cbus, periphs, ...) > > here > > aren't there any busses defined in the A1 SoC implementation or are > > were you planning to add them later? > Unlike previous

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-05 Thread Jianxin Pan
Hi Martin, Thanks for the review, we really appreciate your time. Please see my comments below. On 2019/9/6 4:15, Martin Blumenstingl wrote: > Hi Jianxin, > > (it's great to see that you and your team are upstreaming this early) > > On Thu, Sep 5, 2019 at 9:08 AM Jianxin Pan wrote: > [...] >>

Re: [PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-05 Thread Martin Blumenstingl
Hi Jianxin, (it's great to see that you and your team are upstreaming this early) On Thu, Sep 5, 2019 at 9:08 AM Jianxin Pan wrote: [...] > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x800>; > + /*linux,usable-memory =

[PATCH v2 4/4] arm64: dts: add support for A1 based Amlogic AD401

2019-09-05 Thread Jianxin Pan
Add basic support for the Amlogic A1 based Amlogic AD401 board: which describe components as follows: Reserve Memory, CPU, GIC, IRQ, Timer, UART. It's capable of booting up into the serial console. Signed-off-by: Jianxin Pan Reviewed-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/Makefile