Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Darren Hart
On Thu, Jun 09, 2016 at 01:33:48PM +0200, Pali Rohár wrote: > On Thursday 09 June 2016 13:27:21 Michał Kępień wrote: > > > > - case 0x10: > > > > - /* Keys pressed */ > > > > + case 0x0010: > > > > + /* Sequence of keys

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Darren Hart
On Thu, Jun 09, 2016 at 01:33:48PM +0200, Pali Rohár wrote: > On Thursday 09 June 2016 13:27:21 Michał Kępień wrote: > > > > - case 0x10: > > > > - /* Keys pressed */ > > > > + case 0x0010: > > > > + /* Sequence of keys

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Pali Rohár
On Thursday 09 June 2016 13:27:21 Michał Kępień wrote: > > > - case 0x10: > > > - /* Keys pressed */ > > > + case 0x0010: > > > + /* Sequence of keys pressed */ > > > > > > for (i = 2; i < len; ++i) > > > > > > -

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Pali Rohár
On Thursday 09 June 2016 13:27:21 Michał Kępień wrote: > > > - case 0x10: > > > - /* Keys pressed */ > > > + case 0x0010: > > > + /* Sequence of keys pressed */ > > > > > > for (i = 2; i < len; ++i) > > > > > > -

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Michał Kępień
> > - case 0x10: > > - /* Keys pressed */ > > + case 0x0010: > > + /* Sequence of keys pressed */ > > for (i = 2; i < len; ++i) > > - dell_wmi_process_key(buffer_entry[i]); > > +

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-09 Thread Michał Kępień
> > - case 0x10: > > - /* Keys pressed */ > > + case 0x0010: > > + /* Sequence of keys pressed */ > > for (i = 2; i < len; ++i) > > - dell_wmi_process_key(buffer_entry[i]); > > +

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-08 Thread Darren Hart
On Wed, Jun 08, 2016 at 01:32:27AM +0200, Pali Rohár wrote: > This patch unify procedure for generating sparse keymap and unify also big > switch code for processing WMI events of different types. After this patch > dell-wmi driver does not differ between "old" and "new" hotkey type. > > It

Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-08 Thread Darren Hart
On Wed, Jun 08, 2016 at 01:32:27AM +0200, Pali Rohár wrote: > This patch unify procedure for generating sparse keymap and unify also big > switch code for processing WMI events of different types. After this patch > dell-wmi driver does not differ between "old" and "new" hotkey type. > > It

[PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-07 Thread Pali Rohár
This patch unify procedure for generating sparse keymap and unify also big switch code for processing WMI events of different types. After this patch dell-wmi driver does not differ between "old" and "new" hotkey type. It construct sparse keymap table with all WMI codes. It is because on some

[PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

2016-06-07 Thread Pali Rohár
This patch unify procedure for generating sparse keymap and unify also big switch code for processing WMI events of different types. After this patch dell-wmi driver does not differ between "old" and "new" hotkey type. It construct sparse keymap table with all WMI codes. It is because on some