Re: [PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-23 Thread Corentin Labbe
On Mon, May 22, 2017 at 02:49:44PM -0400, David Miller wrote: > From: Corentin Labbe > Date: Mon, 22 May 2017 14:33:47 +0200 > > > - mac->link.port = GMAC_CONTROL_PS; > > mac->link.duplex = GMAC_CONTROL_DM; > > - mac->link.speed = GMAC_CONTROL_FES; > > +

Re: [PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-23 Thread Corentin Labbe
On Mon, May 22, 2017 at 02:49:44PM -0400, David Miller wrote: > From: Corentin Labbe > Date: Mon, 22 May 2017 14:33:47 +0200 > > > - mac->link.port = GMAC_CONTROL_PS; > > mac->link.duplex = GMAC_CONTROL_DM; > > - mac->link.speed = GMAC_CONTROL_FES; > > + mac->link.speed10 =

Re: [PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-22 Thread David Miller
From: Corentin Labbe Date: Mon, 22 May 2017 14:33:47 +0200 > The current stmmac_adjust_link() part which handle speed have > some if (has_platform) code and my dwmac-sun8i will add more of them. > > So we need to handle better speed selection. > Moreover the struct

Re: [PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-22 Thread David Miller
From: Corentin Labbe Date: Mon, 22 May 2017 14:33:47 +0200 > The current stmmac_adjust_link() part which handle speed have > some if (has_platform) code and my dwmac-sun8i will add more of them. > > So we need to handle better speed selection. > Moreover the struct link member speed and port

[PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-22 Thread Corentin Labbe
The current stmmac_adjust_link() part which handle speed have some if (has_platform) code and my dwmac-sun8i will add more of them. So we need to handle better speed selection. Moreover the struct link member speed and port are hard to guess their purpose. And their unique usage are to be

[PATCH v2 4/4] net-next: stmmac: rework the speed selection

2017-05-22 Thread Corentin Labbe
The current stmmac_adjust_link() part which handle speed have some if (has_platform) code and my dwmac-sun8i will add more of them. So we need to handle better speed selection. Moreover the struct link member speed and port are hard to guess their purpose. And their unique usage are to be