Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-30 Thread Valentin Schneider
On 29/08/2019 15:19, Vincent Guittot wrote: [...] >> Right, if we end up kicking the cpu_stopper this can still happen (since >> we drop the lock). Thing is, you can't detect it on the cpu_stopper side, >> since the currently running is obviously not going to be CFS (and it's >> too late anyway,

Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-29 Thread Vincent Guittot
On Wed, 28 Aug 2019 at 11:46, Valentin Schneider wrote: > > On 27/08/2019 13:28, Vincent Guittot wrote: > > On Thu, 15 Aug 2019 at 16:52, Valentin Schneider > > wrote: > >> > >> The CFS load balancer can cause the cpu_stopper to run a function to > >> try and steal a remote rq's running task.

Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-28 Thread Valentin Schneider
On 27/08/2019 13:28, Vincent Guittot wrote: > On Thu, 15 Aug 2019 at 16:52, Valentin Schneider > wrote: >> >> The CFS load balancer can cause the cpu_stopper to run a function to >> try and steal a remote rq's running task. However, it so happens >> that while only CFS tasks will ever be migrated

Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-27 Thread Vincent Guittot
On Thu, 15 Aug 2019 at 16:52, Valentin Schneider wrote: > > The CFS load balancer can cause the cpu_stopper to run a function to > try and steal a remote rq's running task. However, it so happens > that while only CFS tasks will ever be migrated by that function, we > can end up preempting higher

[PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-15 Thread Valentin Schneider
The CFS load balancer can cause the cpu_stopper to run a function to try and steal a remote rq's running task. However, it so happens that while only CFS tasks will ever be migrated by that function, we can end up preempting higher sched class tasks, since it is executed by the cpu_stopper. This