Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-23 Thread Pierre Morel
On 22/08/2018 19:07, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) No it was

Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-23 Thread Pierre Morel
On 22/08/2018 19:07, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) No it was

Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread David Hildenbrand
On 22.08.2018 18:51, Pierre Morel wrote: > BUG: the crycbd must be tested for null even if > not crossing a page boundary (which will never > occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) Either we return or we check for !crycb_addr > >

Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread David Hildenbrand
On 22.08.2018 18:51, Pierre Morel wrote: > BUG: the crycbd must be tested for null even if > not crossing a page boundary (which will never > occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) Either we return or we check for !crycb_addr > >

[PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread Pierre Morel
BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). Signed-off-by: Pierre Morel --- arch/s390/kvm/vsie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c index

[PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread Pierre Morel
BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). Signed-off-by: Pierre Morel --- arch/s390/kvm/vsie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c index