Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-09-07 Thread Adrian Hunter
On 4/09/20 8:43 am, Ian Rogers wrote: > On Tue, Aug 4, 2020 at 8:50 AM Ian Rogers wrote: >> On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote: >>> On 4/08/20 4:33 pm, Ian Rogers wrote: On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter wrote: > On 28/07/20 11:57 am, Ian Rogers wrote:

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-09-03 Thread Ian Rogers
On Tue, Aug 4, 2020 at 8:50 AM Ian Rogers wrote: > > On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote: > > > > On 4/08/20 4:33 pm, Ian Rogers wrote: > > > On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter > > > wrote: > > >> > > >> On 28/07/20 11:57 am, Ian Rogers wrote: > > >>> If events in a

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Ian Rogers
On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote: > > On 4/08/20 4:33 pm, Ian Rogers wrote: > > On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter > > wrote: > >> > >> On 28/07/20 11:57 am, Ian Rogers wrote: > >>> If events in a group explicitly set a frequency or period with leader > >>> sampling,

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Adrian Hunter
On 4/08/20 4:33 pm, Ian Rogers wrote: > On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter wrote: >> >> On 28/07/20 11:57 am, Ian Rogers wrote: >>> If events in a group explicitly set a frequency or period with leader >>> sampling, don't disable the samples on those events. >>> >>> Prior to 5.8: >>>

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Ian Rogers
On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter wrote: > > On 28/07/20 11:57 am, Ian Rogers wrote: > > If events in a group explicitly set a frequency or period with leader > > sampling, don't disable the samples on those events. > > > > Prior to 5.8: > > perf record -e

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Adrian Hunter
On 28/07/20 11:57 am, Ian Rogers wrote: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' Might be worth explaining this

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:33AM -0700, Ian Rogers escreveu: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear

[PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-07-28 Thread Ian Rogers
If events in a group explicitly set a frequency or period with leader sampling, don't disable the samples on those events. Prior to 5.8: perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' would clear the attributes then apply the config terms. In commit 5f34278867b7 leader