Re: [PATCH v2 4/5] tracing: Unify the logic for function tracing options

2021-04-07 Thread Yordan Karadzhov (VMware)
Hi Steven, Hi Steven, On 6.04.21 г. 1:15, Steven Rostedt wrote: @@ -235,30 +248,31 @@ static struct tracer function_trace; static int func_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set) { - switch (bit) { - case TRACE_FUNC_OPT_STACK: - /*

Re: [PATCH v2 4/5] tracing: Unify the logic for function tracing options

2021-04-05 Thread Steven Rostedt
On Mon, 29 Mar 2021 16:05:32 +0300 "Yordan Karadzhov (VMware)" wrote: > Currently the logic for dealing with the options for function tracing > has two different implementations. One is used when we set the flags > (in "static int func_set_flag()") and another used when we initialize > the

[PATCH v2 4/5] tracing: Unify the logic for function tracing options

2021-03-29 Thread Yordan Karadzhov (VMware)
Currently the logic for dealing with the options for function tracing has two different implementations. One is used when we set the flags (in "static int func_set_flag()") and another used when we initialize the tracer (in "static int function_trace_init()"). Those two implementations are meant