Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

On Fri, Sep 6, 2019 at 5:14 PM Segher Boessenkool wrote: > > On Fri, Sep 06, 2019 at 04:42:58PM -0700, Nick Desaulniers via gcc-patches > wrote: > > Just to prove my point about version checks being brittle, it looks > > like Rasmus' version check isn't even right. GCC supported `asm > > inline`

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

On Fri, Sep 6, 2019 at 3:03 PM Segher Boessenkool wrote: > > On Fri, Sep 06, 2019 at 11:14:08AM -0700, Nick Desaulniers wrote: > > Here's the case that I think is perfect: > > https://developers.redhat.com/blog/2016/02/25/new-asm-flags-feature-for-x86-in-gcc-6/ > > > > Specifically the feature tes

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

On 05/09/2019 15.45, Segher Boessenkool wrote: > Hi Rasmus, > > On Thu, Sep 05, 2019 at 01:07:11PM +0200, Rasmus Villemoes wrote: >> On 05/09/2019 02.18, Nick Desaulniers wrote: >>> Is it too late to ask for a feature test macro? Maybe one already >>> exists? >> >> No, not as far as I know. > >

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

Hi Rasmus, On Thu, Sep 05, 2019 at 01:07:11PM +0200, Rasmus Villemoes wrote: > On 05/09/2019 02.18, Nick Desaulniers wrote: > > Is it too late to ask for a feature test macro? Maybe one already > > exists? > > No, not as far as I know. [ That's not what a feature test macro is; a feature test m

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

> On Sep 4, 2019, at 5:18 PM, Nick Desaulniers wrote: > > On Fri, Aug 30, 2019 at 4:15 PM Rasmus Villemoes > wrote: >> This adds an asm_inline macro which expands to "asm inline" [1] when gcc >> is new enough (>= 9.1), and just asm for older gccs and other >> compilers. >> >> Using asm inline("

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

On Fri, Aug 30, 2019 at 4:15 PM Rasmus Villemoes wrote: > > This adds an asm_inline macro which expands to "asm inline" [1] when gcc > is new enough (>= 9.1), and just asm for older gccs and other > compilers. > > Using asm inline("foo") instead of asm("foo") overrules gcc's > heuristic estimate o

[PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

This adds an asm_inline macro which expands to "asm inline" [1] when gcc is new enough (>= 9.1), and just asm for older gccs and other compilers. Using asm inline("foo") instead of asm("foo") overrules gcc's heuristic estimate of the size of the code represented by the asm() statement, and makes g