Re: [PATCH v2 4/6] cx88: use generic power management

2020-07-17 Thread Vaibhav Gupta
On Fri, Jul 17, 2020 at 12:49:43PM +0200, Hans Verkuil wrote: > On 17/07/2020 12:31, Vaibhav Gupta wrote: > > On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote: > >> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: > >>> Hi Vaibhav, > >>> > >>> Thank you for the patch!

Re: [PATCH v2 4/6] cx88: use generic power management

2020-07-17 Thread Hans Verkuil
On 17/07/2020 12:31, Vaibhav Gupta wrote: > On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote: >> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: >>> Hi Vaibhav, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on linuxtv-media

Re: [PATCH v2 4/6] cx88: use generic power management

2020-07-17 Thread Vaibhav Gupta
On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote: > On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: > > Hi Vaibhav, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on linuxtv-media/master] > > [also build test ERROR on pci/

Re: [PATCH v2 4/6] cx88: use generic power management

2020-07-17 Thread Vaibhav Gupta
On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: > Hi Vaibhav, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on pci/next v5.8-rc5 next-20200716] > [If your patch is applied to the wrong git tre

Re: [PATCH v2 4/6] cx88: use generic power management

2020-07-17 Thread kernel test robot
Hi Vaibhav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on pci/next v5.8-rc5 next-20200716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' a

[PATCH v2 4/6] cx88: use generic power management

2020-07-16 Thread Vaibhav Gupta
With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific operations. The driver was invoking PCI help