Re: [PATCH v2 4/6] virtio-gpu: add 3d/virgl support

Hi, > > static unsigned int features[] = { > > +#ifdef __LITTLE_ENDIAN > > + VIRTIO_GPU_FEATURE_VIRGL, > > +#endif > > }; > > Why is virgl LE specific? Just curious. gallium command stream is native endian, and we only support little endian guests on little endian hosts for that reason.

Re: [PATCH v2 4/6] virtio-gpu: add 3d/virgl support

Hi, > > static unsigned int features[] = { > > +#ifdef __LITTLE_ENDIAN > > + VIRTIO_GPU_FEATURE_VIRGL, > > +#endif > > }; > > Why is virgl LE specific? Just curious. gallium command stream is native endian, and we only support little endian guests on little endian hosts for that reason.

Re: [PATCH v2 4/6] virtio-gpu: add 3d/virgl support

On Mon, Sep 21, 2015 at 11:40:15AM +0200, Gerd Hoffmann wrote: > Add the bits needed for opengl rendering support: query > capabilities, new virtio commands, drm ioctls. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann Looks good to me overall. Some minor comments below. I had

[PATCH v2 4/6] virtio-gpu: add 3d/virgl support

Add the bits needed for opengl rendering support: query capabilities, new virtio commands, drm ioctls. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/Makefile| 3 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 10 +

Re: [PATCH v2 4/6] virtio-gpu: add 3d/virgl support

On Mon, Sep 21, 2015 at 11:40:15AM +0200, Gerd Hoffmann wrote: > Add the bits needed for opengl rendering support: query > capabilities, new virtio commands, drm ioctls. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann Looks good to me

[PATCH v2 4/6] virtio-gpu: add 3d/virgl support

Add the bits needed for opengl rendering support: query capabilities, new virtio commands, drm ioctls. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/Makefile| 3 +- drivers/gpu/drm/virtio/virtgpu_drv.c |