Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Tue, 2018-06-12 at 17:58 +0800, Sean Wang wrote: > On Wed, 2018-05-30 at 08:26 +0200, Marcel Holtmann wrote: > > Hi Sean, > > > > >> > > [ ... ] > > > >>> * Unknown packet (code 14 len 30) > > >>> 0.641509 > > >>> 01 00 00 00 02 00 01 0e 00 01

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Tue, 2018-06-12 at 17:58 +0800, Sean Wang wrote: > On Wed, 2018-05-30 at 08:26 +0200, Marcel Holtmann wrote: > > Hi Sean, > > > > >> > > [ ... ] > > > >>> * Unknown packet (code 14 len 30) > > >>> 0.641509 > > >>> 01 00 00 00 02 00 01 0e 00 01

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Wed, 2018-05-30 at 08:26 +0200, Marcel Holtmann wrote: > Hi Sean, > > >> [ ... ] > >>> * Unknown packet (code 14 len 30) > >>> 0.641509 > >>> 01 00 00 00 02 00 01 0e 00 01 00 00 00 10 62 6c ..bl > >>> 75 65 74 6f 6f 74 68 64

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Wed, 2018-05-30 at 08:26 +0200, Marcel Holtmann wrote: > Hi Sean, > > >> [ ... ] > >>> * Unknown packet (code 14 len 30) > >>> 0.641509 > >>> 01 00 00 00 02 00 01 0e 00 01 00 00 00 10 62 6c ..bl > >>> 75 65 74 6f 6f 74 68 64

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, >> >> [ ... ] > > [ ... ] > >>> I post it as plain text as below >>> >>> >>> Bluetooth monitor ver 5.37 >>> = Note: Linux version 4.16.0-rc1+ (aarch64) >>> 0.641494 >>> = Note: Bluetooth subsystem version 2.22 >>>

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, >> >> [ ... ] > > [ ... ] > >>> I post it as plain text as below >>> >>> >>> Bluetooth monitor ver 5.37 >>> = Note: Linux version 4.16.0-rc1+ (aarch64) >>> 0.641494 >>> = Note: Bluetooth subsystem version 2.22 >>>

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Thu, 2018-05-24 at 09:47 +0200, Marcel Holtmann wrote: > Hi Sean, > > > [ ... ] [ ... ] > > I post it as plain text as below > > > > > > Bluetooth monitor ver 5.37 > > = Note: Linux version 4.16.0-rc1+ (aarch64) > > 0.641494 > > = Note: Bluetooth

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Thu, 2018-05-24 at 09:47 +0200, Marcel Holtmann wrote: > Hi Sean, > > > [ ... ] [ ... ] > > I post it as plain text as below > > > > > > Bluetooth monitor ver 5.37 > > = Note: Linux version 4.16.0-rc1+ (aarch64) > > 0.641494 > > = Note: Bluetooth

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, [ ... ] >> -if (hci_dev_test_flag(hdev, HCI_SETUP)) { >> +if (hci_dev_test_flag(hdev, HCI_SETUP) || >> +test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { >> hci_sock_dev_event(hdev, HCI_DEV_SETUP); > > I am

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, [ ... ] >> -if (hci_dev_test_flag(hdev, HCI_SETUP)) { >> +if (hci_dev_test_flag(hdev, HCI_SETUP) || >> +test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { >> hci_sock_dev_event(hdev, HCI_DEV_SETUP); > > I am

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Wed, 2018-05-23 at 14:31 +0200, Marcel Holtmann wrote: > Hi Sean, > > >> > >> [ ... ] > >> > -if (hci_dev_test_flag(hdev, HCI_SETUP)) { > +if (hci_dev_test_flag(hdev, HCI_SETUP) || > +test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { >

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Wed, 2018-05-23 at 14:31 +0200, Marcel Holtmann wrote: > Hi Sean, > > >> > >> [ ... ] > >> > -if (hci_dev_test_flag(hdev, HCI_SETUP)) { > +if (hci_dev_test_flag(hdev, HCI_SETUP) || > +test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { >

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, >> >> [ ... ] >> - if (hci_dev_test_flag(hdev, HCI_SETUP)) { + if (hci_dev_test_flag(hdev, HCI_SETUP) || + test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { hci_sock_dev_event(hdev, HCI_DEV_SETUP); >>> >>> I am not 100% sure that we want to

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, >> >> [ ... ] >> - if (hci_dev_test_flag(hdev, HCI_SETUP)) { + if (hci_dev_test_flag(hdev, HCI_SETUP) || + test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { hci_sock_dev_event(hdev, HCI_DEV_SETUP); >>> >>> I am not 100% sure that we want to

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Tue, 2018-05-22 at 09:21 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > > - if (hci_dev_test_flag(hdev, HCI_SETUP)) { > > + if (hci_dev_test_flag(hdev, HCI_SETUP) || > > + test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { > > hci_sock_dev_event(hdev,

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

On Tue, 2018-05-22 at 09:21 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > > - if (hci_dev_test_flag(hdev, HCI_SETUP)) { > > + if (hci_dev_test_flag(hdev, HCI_SETUP) || > > + test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, >quirks)) { > > hci_sock_dev_event(hdev,

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, > Add a new quirk HCI_QUIRK_NON_PERSISTENT_SETUP allowing that a quirk that > runs setup() after every open() and not just after the first open(). > > Signed-off-by: Sean Wang > --- > include/net/bluetooth/hci.h | 9 + > net/bluetooth/hci_core.c| 3

Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

Hi Sean, > Add a new quirk HCI_QUIRK_NON_PERSISTENT_SETUP allowing that a quirk that > runs setup() after every open() and not just after the first open(). > > Signed-off-by: Sean Wang > --- > include/net/bluetooth/hci.h | 9 + > net/bluetooth/hci_core.c| 3 ++- > 2 files changed, 11

[PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

From: Sean Wang Add a new quirk HCI_QUIRK_NON_PERSISTENT_SETUP allowing that a quirk that runs setup() after every open() and not just after the first open(). Signed-off-by: Sean Wang --- include/net/bluetooth/hci.h | 9 +

[PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

From: Sean Wang Add a new quirk HCI_QUIRK_NON_PERSISTENT_SETUP allowing that a quirk that runs setup() after every open() and not just after the first open(). Signed-off-by: Sean Wang --- include/net/bluetooth/hci.h | 9 + net/bluetooth/hci_core.c| 3 ++- 2 files changed, 11