Re: [PATCH v2 5/5] mm/migrate.c: fix potential deadlock in NUMA balancing shared exec THP case

2021-03-23 Thread Miaohe Lin
On 2021/3/24 9:16, Yang Shi wrote: > On Tue, Mar 23, 2021 at 10:17 AM Yang Shi wrote: >> >> On Tue, Mar 23, 2021 at 6:55 AM Miaohe Lin wrote: >>> >>> Since commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA >>> balancing"), the NUMA balancing would skip shared exec transhuge page.

Re: [PATCH v2 5/5] mm/migrate.c: fix potential deadlock in NUMA balancing shared exec THP case

2021-03-23 Thread Miaohe Lin
On 2021/3/24 1:17, Yang Shi wrote: > On Tue, Mar 23, 2021 at 6:55 AM Miaohe Lin wrote: >> >> Since commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA >> balancing"), the NUMA balancing would skip shared exec transhuge page. >> But this enhancement is not suitable for transhuge page.

Re: [PATCH v2 5/5] mm/migrate.c: fix potential deadlock in NUMA balancing shared exec THP case

2021-03-23 Thread Yang Shi
On Tue, Mar 23, 2021 at 10:17 AM Yang Shi wrote: > > On Tue, Mar 23, 2021 at 6:55 AM Miaohe Lin wrote: > > > > Since commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA > > balancing"), the NUMA balancing would skip shared exec transhuge page. > > But this enhancement is not

Re: [PATCH v2 5/5] mm/migrate.c: fix potential deadlock in NUMA balancing shared exec THP case

2021-03-23 Thread Yang Shi
On Tue, Mar 23, 2021 at 6:55 AM Miaohe Lin wrote: > > Since commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA > balancing"), the NUMA balancing would skip shared exec transhuge page. > But this enhancement is not suitable for transhuge page. Because it's > required that

[PATCH v2 5/5] mm/migrate.c: fix potential deadlock in NUMA balancing shared exec THP case

2021-03-23 Thread Miaohe Lin
Since commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA balancing"), the NUMA balancing would skip shared exec transhuge page. But this enhancement is not suitable for transhuge page. Because it's required that page_mapcount() must be 1 due to no migration pte dance is done here. On